Address review feedback from PR #485 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @KyleFromKitware This does not need a formal review. It just addresses post-merge review comments from PR #485. I am going to go ahead and merge this so that I can snapshot TriBITS into a new Trilinos branch and get a Trilinos PR posted for that. |
rabartlett1972
previously approved these changes
Jun 10, 2022
There was a problem hiding this comment.
CC: @KyleFromKitware
This does not need a formal review. It just addresses post-merge review comments from PR #485.
I am going to go ahead and merge this so that I can snapshot TriBITS into a new Trilinos branch and get a Trilinos PR posted for that.
In this case, there are no spaces in the --pretty=format:<value> argument so we don't need the quotes and therefore don't need to suffer the complexity of removing them after the fact. But note the case I copied and pasted this from in tribits_generate_single_repo_version_string() still requires them because that format spec has spaces.
This was caught in review by @KyleFromKitware. Turns out that TriBITS was using find_program(Git) everywhere else already.
It was pointed out by @KyleFromKitware in the review of PR #485 that calling cmake_policy() in a function will change a policy in the calling scope. NOTE: The function() command does not create a new policy scope but does create a new variable scope. Just the opposite, include() creates a new policy scope but not a new variable scope.
With newer CMake version, you can just quote the entire argument: "--pretty=format:<fmnt>" where <fmnt> may have spaces and everything seems to work correctly.
bartlettroscoe
force-pushed
the
485-address-review-comments
branch
from
4bd215a to
e82c454
Compare
rabartlett1972
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses post-merge review comments from PR #485 from @KyleFromKitware.
See the commits and commit logs for more details.