-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDash URLs to all builds and failing tests for a given repo revision #483
Comments
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 2, 2022
I will be adding functions for getting CDash URLs other than just for builds.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 2, 2022
This is part of a refactoring to display more CDash URLs other than just build URLs.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 2, 2022
…#483) We need to be breaking up TribitsGlobalMacros.cmake because it is too long. I also added a new function to get just the 40-char SHA1.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 2, 2022
…Pub#483) This was not printing out the semi-colons in a list passed to message_wrapper(). I noticed this while working on TriBITSPub#483.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 2, 2022
This makes the module TribitsGeneralMacros.cmake smaller and better aggregates these commands. I also added a new macro tribits_assert_parse_arg_one_value() which I just tested manually. It is a very simple macro so I am not too worried about not unit testing it yet.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 2, 2022
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 3, 2022
This is to make the file easier to navigate so I can add more unit tests. This file has gotten way too big and needs to be broken into several smaller files at some point here.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 3, 2022
…Pub#483) This was not printing out the semi-colons in a list passed to message_wrapper(). I noticed this while working on TriBITSPub#483.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 3, 2022
I also updated the documentation some for unittest_string_regex(). I do not run the new function unittest_string_var_regex() in this commit but will in a later commit where I manually tested as part of work for TriBITSPub#483 to ensure it passes and fails when it should.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 3, 2022
This makes the module TribitsGeneralMacros.cmake smaller and better aggregates these commands. I also added a new macro tribits_assert_parse_arg_one_value() which I just tested manually. It is a very simple macro so I am not too worried about not unit testing it yet.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 3, 2022
…ITSPub#483) This allows more compact argument parsing code and checking
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 3, 2022
…#483) We need to be breaking up TribitsGlobalMacros.cmake because it is too long. I also added a new function to get just the 40-char SHA1 and I added unit tests for it.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 3, 2022
This comes up with refactorings being done for TriBITSPub#483.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 3, 2022
I will be adding functions for getting CDash URLs other than just for builds.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 3, 2022
This is part of a refactoring to display more CDash URLs other than just build URLs.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 5, 2022
…riBITSPub#483) This will make this easy to reuse to get other CDash URLs.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 5, 2022
…epo version (TriBITSPub#483) ToDo: This code seeems to produce the correct URLs but I need to add strong tests to lock this down.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 5, 2022
…ITSPub#483) This will make this easier to reuse to get other CDash URLs.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 5, 2022
…ersion (TriBITSPub#483) This makes it easy to click on links to these other CDash URLs to see what is happening with all of the builds for the same repo version. The main target is for the GitHub Actions drivers for TriBITS testing. This makes it easy to get at those results.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 5, 2022
…ersion (TriBITSPub#483) This makes it easy to click on links to these other CDash URLs to see what is happening with all of the builds for the same repo version. The main target is for the GitHub Actions drivers for TriBITS testing. This makes it easy to get at those results.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 5, 2022
…ersion (TriBITSPub#483) This makes it easy to click on links to these other CDash URLs to see what is happening with all of the builds for the same repo version. The main target is for the GitHub Actions drivers for TriBITS testing. This makes it easy to get at those results.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 5, 2022
…ersion (TriBITSPub#483) This makes it easy to click on links to these other CDash URLs to see what is happening with all of the builds for the same repo version. The main target is for the GitHub Actions drivers for TriBITS testing. This makes it easy to get at those results. As part of this, I also renamed the function tribits_get_build_url_and_write_to_file() to tribits_get_cdash_build_url() and removed the ability to write to a file. (We just don't need that anymore and it is trivial to write a string to a file.)
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 6, 2022
…ersion (TriBITSPub#483) This makes it easy to click on links to these other CDash URLs to see what is happening with all of the builds for the same repo version. The main target is for the GitHub Actions drivers for TriBITS testing. This makes it easy to get at those results. As part of this, I also renamed the function tribits_get_build_url_and_write_to_file() to tribits_get_cdash_build_url() and removed the ability to write to a file. (We just don't need that anymore and it is trivial to write a string to a file.)
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
This is to make the file easier to navigate so I can add more unit tests. This file has gotten way too big and needs to be broken into several smaller files at some point here.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
…Pub#483) This was not printing out the semi-colons in a list passed to message_wrapper(). I noticed this while working on TriBITSPub#483.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
I also updated the documentation some for unittest_string_regex(). I do not run the new function unittest_string_var_regex() in this commit but will in a later commit where I manually tested as part of work for TriBITSPub#483 to ensure it passes and fails when it should.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
This makes the module TribitsGeneralMacros.cmake smaller and better aggregates these commands. I also added a new macro tribits_assert_parse_arg_one_value() which I just tested manually. It is a very simple macro so I am not too worried about not unit testing it yet.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
This is to make the file easier to navigate so I can add more unit tests. This file has gotten way too big and needs to be broken into several smaller files at some point here.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
…Pub#483) This was not printing out the semi-colons in a list passed to message_wrapper(). I noticed this while working on TriBITSPub#483.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
I also updated the documentation some for unittest_string_regex(). I do not run the new function unittest_string_var_regex() in this commit but will in a later commit where I manually tested as part of work for TriBITSPub#483 to ensure it passes and fails when it should.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
This makes the module TribitsGeneralMacros.cmake smaller and better aggregates these commands. I also added a new macro tribits_assert_parse_arg_one_value() which I just tested manually. It is a very simple macro so I am not too worried about not unit testing it yet.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
…ITSPub#483) This allows more compact argument parsing code and checking
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
…#483) We need to be breaking up TribitsGlobalMacros.cmake because it is too long. I also added a new function to get just the 40-char SHA1 and I added unit tests for it.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
This comes up with refactorings being done for TriBITSPub#483.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
I will be adding functions for getting CDash URLs other than just for builds.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
This is part of a refactoring to display more CDash URLs other than just build URLs.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
…ITSPub#483) This will make this easier to reuse to get other CDash URLs.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
…ersion (TriBITSPub#483) This makes it easy to click on links to these other CDash URLs to see what is happening with all of the builds for the same repo version. The main target is for the GitHub Actions drivers for TriBITS testing. This makes it easy to get at those results. As part of this, I also renamed the function tribits_get_build_url_and_write_to_file() to tribits_get_cdash_build_url() and removed the ability to write to a file. (We just don't need that anymore and it is trivial to write a string to a file.)
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
…#483) We need to be breaking up TribitsGlobalMacros.cmake because it is too long.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
This will be a robust way to generate the CDash URLs that contain 'Revision' for when the base git repos can't produce a SHA1. And this is just a very generally useful function.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
This comes up with refactorings being done for TriBITSPub#483.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
I will be adding functions for getting more CDash URLs that for just this one build's results.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
This is part of a refactoring to display more CDash URLs other than just build URLs.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
…ITSPub#483) This will make this easier to reuse to get other CDash URLs.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 7, 2022
…ersion (TriBITSPub#483) This makes it easy to click on links to these other CDash URLs to see what is happening with all of the builds for the same repo version. The main target is for the GitHub Actions drivers for TriBITS testing. This makes it easy to get at those results. As part of this, I also renamed the function tribits_get_build_url_and_write_to_file() to tribits_get_cdash_build_url() and removed the ability to write to a file. (We just don't need that anymore and it is trivial to write a string to a file.)
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 10, 2022
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 10, 2022
In this case, there are no spaces in the --pretty=format:<value> argument so we don't need the quotes and therefore don't need to suffer the complexity of removing them after the fact. But note the case I copied and pasted this from in tribits_generate_single_repo_version_string() still requires them because that format spec has spaces.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 10, 2022
This was caught in review by @KyleFromKitware. Turns out that TriBITS was using find_program(Git) everywhere else already.
FYI: I will close this once PR #486 is merged. |
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 10, 2022
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 10, 2022
In this case, there are no spaces in the --pretty=format:<value> argument so we don't need the quotes and therefore don't need to suffer the complexity of removing them after the fact. But note the case I copied and pasted this from in tribits_generate_single_repo_version_string() still requires them because that format spec has spaces.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this issue
Jun 10, 2022
This was caught in review by @KyleFromKitware. Turns out that TriBITS was using find_program(Git) everywhere else already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now the CDash 3.1 supports the "Revision" filter for the index.php and queryTests.php pages, we can construct and display CDash URLs for all builds and failing tests for the same repo version. This will be especially useful for GitHub Actions driven PR testing that runs a set of different builds independently and we want to be able to view the results for all of the related builds.
The text was updated successfully, but these errors were encountered: