Installer detection improvements

[Trenly]

@jedieaston @OfficialEsco

Making some big changes to how the installer entry is built out for new manifests. If you wouldn't mind doing some testing, I'm not sure how stable it is. I think it works, but I haven't gone through every possible use case

[OfficialEsco]

Oooo found a issue when creating a new package, the ProductCode field is not removed when no ProductCode is enterted

  ProductCode: ""

Also, we should probably clear the ReleaseNotes and ReleaseNotesUrl field

[Trenly]

Oooo found a issue when creating a new package, the ProductCode field is not removed when no ProductCode is enterted

  ProductCode: ""

Also, we should probably clear the ReleaseNotes and ReleaseNotesUrl field

I've got a separate branch going for release notes things; I'll merge that into this one and try and fix that product code issue

[OfficialEsco]

I've got a separate branch going for release notes things; I'll merge that into this one

We don't actually have any ReleaseNote or ReleaseNotesUrl metadata tho, so i don't think its too critical, better to merge it when we can input the metadata

Also the ReleaseNotes field sounds scary working with in Powershell

[Trenly]

I've got a separate branch going for release notes things; I'll merge that into this one

We don't actually have any ReleaseNote or ReleaseNotesUrl metadata tho, so i don't think its too critical, better to merge it when we can input the metadata

Also the ReleaseNotes field sounds scary working with in Powershell

It shouldn't be too bad honestly. Its just a string value thats up to 10k characters with multiline support

I'm more worried about ReleaseDate, since that is just a date. Do you know if there is a specific format needed for that? I'm thinking its just yyyy-MM-dd but I'm not 100% sure

[OfficialEsco]

I'm more worried about ReleaseDate, since that is just a date. Do you know if there is a specific format needed for that? I'm thinking its just yyyy-MM-dd but I'm not 100% sure

"ReleaseDate": {
      "type": [ "string", "null" ],
      "format": "date",
      "description": "The installer release date"
    }

Quick testing shows ANYTHING is valid, but we should use (tbh force) yyyy-MM-dd yes

[Trenly]

I'm more worried about ReleaseDate, since that is just a date. Do you know if there is a specific format needed for that? I'm thinking its just yyyy-MM-dd but I'm not 100% sure

"ReleaseDate": {
      "type": [ "string", "null" ],
      "format": "date",
      "description": "The installer release date"
    }

Quick testing shows ANYTHING is valid, but we should use (tbh force) yyyy-MM-dd yes

Perfect; I have it set up (again, different branch) to try and parse whatever the user enters into that format. So they could enter December 30 2021 and it should parse the value to 2021-12-30

[jedieaston]

BTW, the format: "date" means that the date has to be ISO8601, i.e. yyyy-MM-dd. https://json-schema.org/understanding-json-schema/reference/string.html#dates-and-times.

[OfficialEsco]

BTW, the format: "date" means that the date has to be ISO8601, i.e. yyyy-MM-dd. https://json-schema.org/understanding-json-schema/reference/string.html#dates-and-times.

makes sense, seems like winget version 1.2.3131 can't validate it correctly then, cuz i could type anything and it would pass 🤷‍♂️

[OfficialEsco]

Got another bug when creating a new package with 2 installers, microsoft#35217

The script didn’t ask for the unknown archietecture so it just used x64

[Trenly]

Got another bug when creating a new package with 2 installers, microsoft#35217

The script didn’t ask for the unknown archietecture so it just used x64

I haven’t looked fully yet, but it seems like this would occur even when on microsoft/master because the packageidentifier has 64 in it?

[vedantmgoyal9]

@Trenly Does 9e74f09 resolves #28?

[Trenly]

@Trenly Does 9e74f09 resolves #28?

Almost; I still have to figure out the auto update, but yes. Its probably good enough to call it resolved

[vedantmgoyal9]

Typo and Color

[OfficialEsco]

Pretty sure this is approvable at this state 🤔 Unless you want to do more