Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Problem with yaml-language-server comment #121

Closed
vedantmgoyal9 opened this issue Nov 24, 2021 · 0 comments
Closed

[Bug]: Problem with yaml-language-server comment #121

vedantmgoyal9 opened this issue Nov 24, 2021 · 0 comments

Comments

@vedantmgoyal9
Copy link

Brief description of your issue

The script does not write yaml-language-server comment properly in locales other than the en-US.

Steps to reproduce

  1. Generate a manifest with locales:
    • en-US
    • any other locale
  2. Observe the second locale file and you will find this:
    # yaml-language-server: =https://aka.ms/winget-manifest.locale.1.1.0.schema.json
    instead of:
    # yaml-language-server: $schema=https://aka.ms/winget-manifest.locale.1.1.0.schema.json
  3. That's all.

Expected behavior

# yaml-language-server: **$schema**=https://aka.ms/winget-manifest.locale.1.1.0.schema.json

(put * for attention)

Actual behavior

# yaml-language-server: =https://aka.ms/winget-manifest.locale.1.1.0.schema.json

Environment

YamlCreate v2.0.2
vedantmgoyal9 added a commit to vedantmgoyal9/winget-pkgs that referenced this issue Nov 24, 2021
vedantmgoyal9 added a commit to vedantmgoyal9/winget-pkgs that referenced this issue Nov 24, 2021
vedantmgoyal9 added a commit to vedantmgoyal9/vedantmgoyal9 that referenced this issue Nov 24, 2021
Trenly pushed a commit that referenced this issue Nov 24, 2021
@Trenly Trenly closed this as completed Nov 24, 2021
ghost pushed a commit to microsoft/winget-pkgs that referenced this issue Nov 24, 2021
* Update: KDE.Kate version 21.08.3

* Trenly#121

Co-authored-by: winget-pkgs-automation-bot[bot] <93540089+winget-pkgs-automation-bot[bot]@users.noreply.github.com>
denelon pushed a commit to microsoft/winget-pkgs that referenced this issue Nov 30, 2021
* Prepare file for 1.1.0 manifests - Trenly#31

* Installer detection improvements (#111)

* Begin update in place

* Condense installer switch logic

* Fix Null values

* Prevent null checking

* Cleanup

* Fix missed variable

* Bump version

* Update function calls

* Fix empty ProductCode

* Confirm Architecture when Automatically Detected

* Remove Debug Line

* Add duplicate url check for Quick update

* Remove line used in debugging

* Remove unneeded comment

* Resolves Trenly#121

Co-authored-by: Vedant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants