Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content-disposition filename regexp #87

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

Waxoussou
Copy link
Contributor

@Waxoussou Waxoussou commented Nov 12, 2024

Related issue: #86 (comment)

  • updating Regex to find filename within content-disposition.
    When filename is not in the last position, some files ended with "; at the end of its name when included in the zip archive.
  • updated related test to reflect that behavior

src/metadata.ts Outdated Show resolved Hide resolved
@Touffy Touffy added the bug Something isn't working label Nov 12, 2024
…th white space + non latin filename in utf8
@Touffy Touffy merged commit 1df94a9 into Touffy:master Nov 13, 2024
1 check passed
Touffy pushed a commit that referenced this pull request Nov 13, 2024
* Fix: Improve Content-Disposition filename matcher - handle white space + extended filename* in UTF-8

---------

Co-authored-by: maxime.abehserra <[email protected]>
Touffy added a commit that referenced this pull request Nov 13, 2024
* Fix: Improve Content-Disposition filename matcher - handle white space + extended filename* in UTF-8

---------

Co-authored-by: maxime.abehserra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants