fix: content-disposition filename regexp (#87)

* Fix: Improve Content-Disposition filename matcher - handle white space + extended filename* in UTF-8 --------- Co-authored-by: maxime.abehserra <[email protected]>
Touffy · Nov 13, 2024 · 1df94a9 · 1df94a9
1 parent ed4b243
commit 1df94a9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/metadata.ts b/src/metadata.ts
@@ -21,7 +21,7 @@ export function normalizeMetadata(input?: File | Response | BufferLike | StreamL
   }
   if (input instanceof Response) {
     const contentDisposition = input.headers.get("content-disposition")
-    const filename = contentDisposition && contentDisposition.match(/;\s*filename\*?=["']?(.*?)["']?$/i)
+    const filename = contentDisposition && contentDisposition.match(/;\s*filename\*?\s*=\s*(?:UTF-\d+''|)["']?([^;"'\r\n]*)["']?(?:;|$)/i);   
     const urlName = filename && filename[1] || input.url && new URL(input.url).pathname.split("/").findLast(Boolean)
     const decoded = urlName && decodeURIComponent(urlName)
     // @ts-ignore allow coercion from null to zero

diff --git a/test/metadata.test.ts b/test/metadata.test.ts
@@ -14,11 +14,19 @@ Deno.test("normalizeMetadata needs a filename along Responses with insufficient
 
 Deno.test("normalizeMetadata guesses filename from Content-Disposition", () => {
   const metadata = normalizeMetadata(new Response("four", {
-    headers: { "content-disposition": "attachment; filename=test.txt" }
+    headers: { "content-disposition": "attachment; filename=test.txt; size=0" }
   }))
   assertEquals(metadata, { uncompressedSize: 0n, encodedName, nameIsBuffer: false })
 })
 
+Deno.test("normalizeMetadata guesses filename from non latin Content-Disposition", () => {
+  const metadata = normalizeMetadata(new Response("four", {
+    headers: { "content-disposition": "attachment; filename* = UTF-8''%CF%8C%CE%BD%CE%BF%CE%BC%CE%B1%20%CE%B1%CF%81%CF%87%CE%B5%CE%AF%CE%BF%CF%85.txt" }
+  }))
+  assertEquals(metadata, { uncompressedSize: 0n,encodedName: new TextEncoder().encode("όνομα αρχείου.txt"), nameIsBuffer: false })
+})
+
+
 Deno.test("normalizeMetadata guesses filename from a Response URL", () => {
   const response = Object.create(Response.prototype, {
     url: { get() { return "https://example.com/path/test.txt" } },