Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetByKey should NOT call GetByKeyList #343

Closed
Grauenwolf opened this issue Jan 31, 2020 · 1 comment
Closed

GetByKey should NOT call GetByKeyList #343

Grauenwolf opened this issue Jan 31, 2020 · 1 comment
Assignees
@Grauenwolf
Labels
Command Builders
Milestone
Tortuga Chain 3.3

Comments

@Grauenwolf
Copy link
Collaborator

This is silly:

public SingleRowDbCommandBuilder<AbstractCommand, AbstractParameter> GetByKey(AbstractObjectName tableName, string key)
{
    return GetByKeyList(tableName, keys: (IEnumerable<string>)new List<string> { key });
}
@Grauenwolf Grauenwolf added this to the Tortuga Chain 3.3 milestone Jan 31, 2020
@Grauenwolf
Copy link
Collaborator Author

Generalized fix goes in Shared\DataSource\DataSourceBase.Class1DataSource.cs

@Grauenwolf Grauenwolf changed the title GetByKey should call GetByKeyList GetByKey should NOT call GetByKeyList Feb 4, 2020
@Grauenwolf Grauenwolf self-assigned this Feb 9, 2020
Grauenwolf added a commit that referenced this issue Feb 9, 2020
@Grauenwolf
GetByKey needs to be reworked to not need explicit table names #342
21b6f7a 
GetByKey should NOT call GetByKeyList #343
@Grauenwolf Grauenwolf mentioned this issue Feb 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Grauenwolf Grauenwolf

Labels
Command Builders
Projects
None yet
Milestone
Tortuga Chain 3.3
Development

No branches or pull requests
1 participant
@Grauenwolf