Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge master + fix bugs #1

Merged
merged 16 commits into from
Aug 19, 2021
Merged

Merge master + fix bugs #1

merged 16 commits into from
Aug 19, 2021

Conversation

soywod
Copy link
Collaborator

@soywod soywod commented Aug 19, 2021

No description provided.

toastal and others added 14 commits August 3, 2021 15:11
@toastal
fix vim plugin + update flake references (pimalaya#182)
f77f33b 
* Nix dependencies updated

* fix vim plugin build
@toastal
remove extra version (pimalaya#183)
63090a2 
* Nix dependencies updated

* fix vim plugin build
@soywod
fix new/reply/forward issue in vim plugin (pimalaya#176)
7b046f8
@soywod
add missing subject prefix for replies
a70631d
@soywod
add basic support of xdg-email (pimalaya#162)
2acd5d7
@soywod
add missing From header when using xdg-email (pimalaya#162)
32d8cf0
@soywod
add config opt signature-delimiter
a6b30b7
@soywod
expand tilde in config file (pimalaya#102)
97054d3
@soywod
make pagination starting at 1 instead of 0 (pimalaya#186)
52e76d1
@soywod
add wiki warning about echo cmd in config passwd-cmd
f92bd62
@soywod
Merge branch 'master' of github.com:soywod/himalaya into mail_refacto…
a79c3a2 
…r_merge_master
@soywod
update install_url from nix gh action
4f05ff6
@soywod
fix integration tests
608057b
@soywod
Merge branch 'master' of github.com:soywod/himalaya into mail_refacto…
e5e2647 
…r_merge_master
@soywod soywod mentioned this pull request Aug 19, 2021
Merged
2 tasks
@TornaxO7 TornaxO7 self-requested a review August 19, 2021 19:22
@TornaxO7 TornaxO7 marked this pull request as ready for review August 19, 2021 19:23
TornaxO7
TornaxO7 reviewed Aug 19, 2021
View reviewed changes
src/config/model.rs Outdated Show resolved Hide resolved
TornaxO7
TornaxO7 reviewed Aug 19, 2021
View reviewed changes
src/main.rs Show resolved Hide resolved
TornaxO7
TornaxO7 reviewed Aug 19, 2021
View reviewed changes
Copy link
Owner

@TornaxO7 TornaxO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soywod Please respond to my questions please :>

@TornaxO7
Copy link
Owner

By the way, I'm sorry if I'm responding a little bit late nowadays. Currently I'm doing a period of practical training and also looking for an apartement, so I can only respond in the evening.

TornaxO7
TornaxO7 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Owner

@TornaxO7 TornaxO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@TornaxO7
Copy link
Owner

TornaxO7 commented Aug 19, 2021 •
edited
Loading

Should I merge now or do you want to apply some changes?

@TornaxO7
Copy link
Owner

(Would be happy if you could still answer my question above ;))

@soywod
Copy link
Collaborator Author

soywod commented Aug 19, 2021 •
edited
Loading

I did all the changes, feel free to add more if you need.

Should I merge now or do you want to apply some changes?

Good question. I propose to merge this one and to create another one for the fixes, what do you think?

@TornaxO7
Copy link
Owner

Agreed! I'll merge it

@TornaxO7 TornaxO7 merged commit 290b538 into mail_refactor Aug 19, 2021
@soywod
Copy link
Collaborator Author

soywod commented Aug 19, 2021

By the way, I'm sorry if I'm responding a little bit late nowadays. Currently I'm doing a period of practical training and also looking for an apartement, so I can only respond in the evening.

Don't worry it's fine, don't forget that this is an open source project, we contribute whenever we can 😄 I mean, the project does not pay the bills (yet, I hope one day 😄). I was also busy these days, I totally understand.

@soywod soywod deleted the mail_refactor_merge_master branch August 19, 2021 20:26
@TornaxO7
Copy link
Owner

Alright, what is still missing?

@soywod
Copy link
Collaborator Author

soywod commented Aug 19, 2021

Thanks 🎉 I will create a draft PR for the fixes.

@TornaxO7
Copy link
Owner

@soywod I'd like to keep working on this branch as well. Could you please tell me what kind of fixes you're trying to implement so I can do the other half?

@soywod
Copy link
Collaborator Author

soywod commented Aug 19, 2021 •
edited
Loading

If I refer to this pimalaya#173 (review) I could take the 2 first (General, Read) and you the 2 last (Reply & Forward, Template)?

@TornaxO7
Copy link
Owner

Aye, we can do this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TornaxO7 TornaxO7 TornaxO7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soywod @TornaxO7 @toastal