Mail/Msg refactoring #173

TornaxO7 · 2021-07-01T10:38:46Z

Hi! I did some changes to the Msg struct. You should be able now to use it for everything which is related to Msgs/Mails. This means:

You can build templates with it
You can reply with it
Edit the body
Add new attachments

and so on.

I'd really appreaciate it, if this could be merged, because the "new" Msg struct will be able to store all related information of a Msg which should make it easier for the TUI to display them.

Hint

It's not completely done yet. You can see below in the TODO section what is missing, but the rest should work.

TODO

Finish the Documentation
Finish/Add Tests

Adding a main structure which can be used for *everything* which has to do with a mail: - Writing a new mail - Fetching the information of a mail

User can write mails now

When mail is converted to a sendable message, it'll print out a nice little error message what to do and which field is missing a value.

List subcommand works with new struct now.

Started implementation for forwarding message

This is just a "backup" commit

Himalaya can compile successfully now.

- Moved everything from msg/mail to msg/model - Removed uneccessary files

Renamed all "Mail" and "Mails" struct to "Msg" and "Msgs".

Removed an CLI-Subcommand which can't be used anymore

Fixed flags to vector and added the template subcommand back

Changed the datatype from Vec<Flag<'static>> to HashSet<Flag<'static>>, because each Message/Mail can include only one flag-type, so why not a HashSet for this job?

Fixed the lettre-dependencie which points to the pull request with the given serde implementation for ContentType (needed for Attachments).

- Removed the msg/flag/flag.rs file since we can use the imap::types::Flag implementation now - `himalaya template new` printed the template two times. This should be fixed now

Fixed formatting when printing out template

Fixed bug that user can't send a mail

Moved the body from the attachment-vector out to an external attribute of the struct.

- Fixed bug that listing didn't showed up addresses in the `From:` field for example - Made each `from` trait function to `try_from` for better error-handling

- Fixed tests in `tests/imap_conn.rs`

- Updated mailparse to 0.13.4 - Added new "new" function to Account - Cleaned up some functions (removed some) - Added Eq and PartialEq derives for msg - Bugfix: It couldn't get the body of some mails, because they were inside a multipart/alternative part. Now the mail is iterating through all subparts and picks up the firs text/plain "attachment" and uses it as the body.

- Made the "main attributes" of the Msg struct public - Removed to getter functions

- Added documentation - Removed the getter functions, beacuse the attributes are public

- Removed the `new` constructor of the envelope, since it's actually the same as Envelope::default() - Addded tests and Documentation to Attachments.rs

- Added docuemntation for msg/body.rs - Fixed some syntax errors in the doc strings

- Added `get_raw` function and `raw` field for the `Msg` struct. - Fixed raw output of msg - Started documentation + tests for the Msg struct

- Added Clone derive - Added documentation for change_to_reply method - Added tests to change_to_reply method

- Changed `Account::new()` function - Added more documentation to Msg struct - Added more tests to Msg struct

TornaxO7 · 2021-08-31T20:33:37Z

So this PR should be ready to merge now 👍

TornaxO7 · 2021-08-31T20:37:11Z

Eh, what are you waiting for? Are you doing a review at the moment? Are you unhappy with something? (Just wondering)

soywod · 2021-09-01T06:01:10Z

So this PR should be ready to merge now 👍

Great, I will review and test the branch one last time, so we don't miss sth.

soywod · 2021-09-01T06:02:16Z

Eh, what are you waiting for? Are you doing a review at the moment? Are you unhappy with something? (Just wondering)

Just sleeping...

TornaxO7 · 2021-09-01T06:03:20Z

Oh sorry 😅

TornaxO7 · 2021-09-05T19:55:47Z

Are you still reviewing?

soywod · 2021-09-05T20:01:41Z

Yes, it's a big PR, I want to take time to test it well. I'm quite busy at work those days, I will finish it as soon as I can.

TornaxO7 · 2021-09-05T20:59:10Z

Ok, I was just wondering because about five days passed now. Take your time! I don't want to put you under pressure!

soywod · 2021-09-08T19:19:41Z

I opened 4 issues on your repo https://github.com/TornaxO7/himalaya/issues.

Changes the order of the signature for forwarded messages.

Changed the output if an error occurs.

…e_with_plain_format

…plate_shows_raw_data_with_json_format

When printing the message in json, the raw message is printed out as a string now.

- When displaying the table, we'll look first, if a name exists, if yes => use it otherwise use the email address. - Added the rfc2047_decoder for parsing addresses

…n_format Template shows raw data with json format

Run 'cargo fmt'

…erly_in_table_and_json

soywod · 2021-09-10T22:11:33Z

If all tests pass, I'm ready to merge!

TornaxO7 · 2021-09-10T22:15:01Z

What the? Why are the tests failing again? They are working locally on my machine ._.

TornaxO7 · 2021-09-10T22:25:22Z

Wait, it's still testing? o.O Nevermind my previous message 😅

TornaxO7 · 2021-09-10T22:25:49Z

Yehaaaw! Tests passed!

soywod · 2021-09-10T22:35:40Z

Congratulations 🎉 and thank you for your patience!

TornaxO7 · 2021-09-10T22:39:27Z

Thanks and thank you for accepting my PR :)

TornaxO7 added 14 commits June 24, 2021 17:14

Adding Mail structure

355e047

Adding a main structure which can be used for *everything* which has to do with a mail: - Writing a new mail - Fetching the information of a mail

Write mails

e77a2f2

User can write mails now

Writing mail

3a785d2

When mail is converted to a sendable message, it'll print out a nice little error message what to do and which field is missing a value.

Mail

b93feb7

List subcommand works with new struct now.

Forwarding

a1d1a32

Started implementation for forwarding message

Breaking Commit

fe1d15b

This is just a "backup" commit

First finished

b2dff7c

Himalaya can compile successfully now.

Removed uneccessary files

7d7e016

- Moved everything from msg/mail to msg/model - Removed uneccessary files

Renaming

e66b911

Renamed all "Mail" and "Mails" struct to "Msg" and "Msgs".

Cleaning

065862b

Removed an CLI-Subcommand which can't be used anymore

Flags

6f46ec4

Fixed flags to vector and added the template subcommand back

Changes to Flags

87a2cda

Changed the datatype from Vec<Flag<'static>> to HashSet<Flag<'static>>, because each Message/Mail can include only one flag-type, so why not a HashSet for this job?

Cargo.toml changes

962e12d

Fixed the lettre-dependencie which points to the pull request with the given serde implementation for ContentType (needed for Attachments).

Fix Template bug and removed unnecessary files.

eaf8fdf

- Removed the msg/flag/flag.rs file since we can use the imap::types::Flag implementation now - `himalaya template new` printed the template two times. This should be fixed now

TornaxO7 marked this pull request as draft July 1, 2021 11:28

Template command

9680c8b

Fixed formatting when printing out template

TornaxO7 mentioned this pull request Jul 2, 2021

Could not append message to Sent if the sending folder is not named Sent #172

Closed

TornaxO7 and others added 13 commits July 2, 2021 19:08

Sending Mail

ff7bb5d

Fixed bug that user can't send a mail

Msg

0dcd6f9

Moved the body from the attachment-vector out to an external attribute of the struct.

Merge branch 'soywod:master' into mail_refactor

d9871b2

Msg listing and changed Msg::from to Msg::try_from

6d5f4b1

- Fixed bug that listing didn't showed up addresses in the `From:` field for example - Made each `from` trait function to `try_from` for better error-handling

Tests

d895f7a

- Fixed tests in `tests/imap_conn.rs`

Changed Msg attributes viewability

e05dd78

- Made the "main attributes" of the Msg struct public - Removed to getter functions

Big envelope changes

2fb8b39

- Added documentation - Removed the getter functions, beacuse the attributes are public

Documentation and Cleanup

8fe610d

- Removed the `new` constructor of the envelope, since it's actually the same as Envelope::default() - Addded tests and Documentation to Attachments.rs

Documentation and Tests

df435e8

- Added docuemntation for msg/body.rs - Fixed some syntax errors in the doc strings

General msg

22efbe2

- Added `get_raw` function and `raw` field for the `Msg` struct. - Fixed raw output of msg - Started documentation + tests for the Msg struct

Changes to Msg

60ae440

- Added Clone derive - Added documentation for change_to_reply method - Added tests to change_to_reply method

Msg tests and Account changes

84ff756

- Changed `Account::new()` function - Added more documentation to Msg struct - Added more tests to Msg struct

This was referenced Sep 8, 2021

Cannot write messages through vim plugin with 'gw' #196

Closed

Quotes in subject are displayed as escaped characters #197

Closed

TornaxO7 and others added 11 commits September 8, 2021 22:22

Forwarded message's signature misplaced

b41d5fe

Changes the order of the signature for forwarded messages.

Output change

01be54a

Changed the output if an error occurs.

Fixing output for template-building

302f961

Merge pull request #25 from TornaxO7/forwarded_message_signature_fix

820550a

Merge pull request #26 from TornaxO7/template_command_shows_blank_lin…

411ec7c

…e_with_plain_format

Merge branch 'mail_refactor' of github.com:TornaxO7/himalaya into tem…

f861aab

…plate_shows_raw_data_with_json_format

Template shows raw data with JSON format #23

4035089

When printing the message in json, the raw message is printed out as a string now.

the_sender_is_not_displayed_properly_in_table_and_json #21

79eea0c

- When displaying the table, we'll look first, if a name exists, if yes => use it otherwise use the email address. - Added the rfc2047_decoder for parsing addresses

Merge pull request #27 from TornaxO7/template_shows_raw_data_with_jso…

aaca1fa

…n_format Template shows raw data with json format

Formatting

9e44466

Run 'cargo fmt'

Merge pull request #28 from TornaxO7/the_sender_is_not_displayed_prop…

57f90fc

…erly_in_table_and_json

soywod merged commit 0e68801 into pimalaya:master Sep 10, 2021

soywod deleted the mail_refactor branch September 10, 2021 22:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mail/Msg refactoring #173

Mail/Msg refactoring #173

TornaxO7 commented Jul 1, 2021 •

edited by soywod

Loading

TornaxO7 commented Aug 31, 2021

TornaxO7 commented Aug 31, 2021

soywod commented Sep 1, 2021

soywod commented Sep 1, 2021

TornaxO7 commented Sep 1, 2021

TornaxO7 commented Sep 5, 2021

soywod commented Sep 5, 2021

TornaxO7 commented Sep 5, 2021

soywod commented Sep 8, 2021

soywod commented Sep 10, 2021

TornaxO7 commented Sep 10, 2021 •

edited

Loading

TornaxO7 commented Sep 10, 2021

TornaxO7 commented Sep 10, 2021

soywod commented Sep 10, 2021

TornaxO7 commented Sep 10, 2021

Mail/Msg refactoring #173

Mail/Msg refactoring #173

Conversation

TornaxO7 commented Jul 1, 2021 • edited by soywod Loading

Hint

TODO

TornaxO7 commented Aug 31, 2021

TornaxO7 commented Aug 31, 2021

soywod commented Sep 1, 2021

soywod commented Sep 1, 2021

TornaxO7 commented Sep 1, 2021

TornaxO7 commented Sep 5, 2021

soywod commented Sep 5, 2021

TornaxO7 commented Sep 5, 2021

soywod commented Sep 8, 2021

soywod commented Sep 10, 2021

TornaxO7 commented Sep 10, 2021 • edited Loading

TornaxO7 commented Sep 10, 2021

TornaxO7 commented Sep 10, 2021

soywod commented Sep 10, 2021

TornaxO7 commented Sep 10, 2021

TornaxO7 commented Jul 1, 2021 •

edited by soywod

Loading

TornaxO7 commented Sep 10, 2021 •

edited

Loading