Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New click-based synchronization system #58 #112

Merged
merged 15 commits into from
Feb 13, 2016
Merged

New click-based synchronization system #58 #112

merged 15 commits into from
Feb 13, 2016

Conversation

MathieuNls
Copy link
Member

The input-based sync system where users had to input the current time after a five seconds countdown was source of errors. Many users were inputing 12 hours-format time instead of 24 and we were likely having a serious issue with timezones...
In this prototype, users have to click a button at the next quarter minute. For ex, if it's 12:20:20, then we'll ask to hit the button at 12:20:30.

I've included some jokes (Almost there youngling, All good, take me home scotty, One does not simply ...) that we could randomize (like the Jack bot). The rule is, however, to keep them short (20 characters space included) so they fit on the popup.

@AlphonseJr, @VS2000, thoughts ?

The input-based sync system where users had to input the current time after a five seconds countdown was source of errors. Many users were inputing 12 hours-format time instead of 24 and we were likely having a serious issue with timezones...
In this prototype, users have to click a button at the next quarter minute. For ex, if it's 12:20:20, then we'll ask to hit the button at 12:20:30.

I included some jokes (Almost there youngling, All good, take me home scotty, One does not simply ...) that we could randomize (like the Jack bot). The rule is, however, to keep them short (20 characters space included) so they fit on the popup.

@AlphonseJr, @VS2000, thoughts ?
@MathieuNls MathieuNls deployed to tw-prepod-pr-112 January 29, 2016 21:59 Active
@MathieuNls MathieuNls added this to the Tw 1.3 milestone Jan 29, 2016
@MathieuNls MathieuNls changed the title New click-based synchronization system #58 [WIP] New click-based synchronization system #58 Jan 29, 2016
@AlphonseJr
Copy link
Collaborator

Can't wait to have a look and start testing :)

@MathieuNls MathieuNls deployed to tw-prepod-pr-112 January 29, 2016 23:14 Active
@MathieuNls MathieuNls deployed to tw-prepod-pr-112 January 29, 2016 23:28 Active
@MathieuNls MathieuNls deployed to tw-prepod-pr-112 January 30, 2016 23:20 Active
@AlphonseJr
Copy link
Collaborator

Petite remarque, il faudrait enlever l'affichage de l'heure sur cette page car ça peut être confusant, l'user ne doit regarder QUE sa montre !

@MathieuNls MathieuNls deployed to tw-prepod-pr-112 January 31, 2016 17:22 Active
@VS2000
Copy link
Collaborator

VS2000 commented Feb 2, 2016

When the second reaches exactly the twelve o'clock position

@VS2000
Copy link
Collaborator

VS2000 commented Feb 7, 2016

Hello, j'ai mis le picto sur slack. Je pense qu'on peut l'intégrer dans le CTA sur la droite du texte.
et là la phrase "When the second reaches exactly the twelve o'clock position" prend tout son sens je trouve. Tenez moi au courant !

@AlphonseJr
Copy link
Collaborator

D'accord avec VS2000 !
Je rajouterai juste "hand" : "When the seconds-hand reaches exactly the twelve o'clock position"

@VS2000
Copy link
Collaborator

VS2000 commented Feb 7, 2016

totalement d'accord cher Alphonse!

@AlphonseJr
Copy link
Collaborator

Yo !

Bon j'ai fait plusieurs mesures sur mobile :

L'affichage pour ce viewport n'est pas encore optimal:

2

Je pense qu'il y a un soucis avec le calcul de la mesure, on a toujours 0.0 sec de précision.

Les images Instagram ne se chargent plus :
0

Dans l'email de result il n'y a pas eu le dashboard :(
1

Il manque l'arobase pour "@Toolwatchapp" dans le share Twitter :(
3

@MathieuNls MathieuNls deployed to tw-prepod-pr-112 February 8, 2016 17:14 Active
@MathieuNls MathieuNls changed the title [WIP] New click-based synchronization system #58 New click-based synchronization system #58 Feb 8, 2016
@MathieuNls MathieuNls mentioned this pull request Feb 9, 2016
@AlphonseJr
Copy link
Collaborator

Je viens de tester, perso je retirerai le picto du CTA, ça fait too much. Je mettrai le picto à droite du CTA et je centrerai les deux.
@MathieuNls : dis nous quand la mesure est fix que je puisse faire un test (d'ailleurs, le tests auto auraient pas du détecter le soucis ?)
Thanks !

@AlphonseJr
Copy link
Collaborator

Une fois synchronisé pour obtenir le résultat, la pop in qui apparaît est la même que quand tu te synchronises la première fois : "le take me home scotty" devrait être remplacé par "give me my accuracy dude"

Thanks !

@MathieuNls MathieuNls deployed to tw-prepod-pr-112 February 12, 2016 18:02 Active
@AlphonseJr
Copy link
Collaborator

All good pour la mesure !
Pour la home, je ferai plutôt un gif, le fait que le bouton soit cliquable et donne un résultat peut être confusant pour un noob marin d'eau douce.

@MathieuNls MathieuNls deployed to tw-prepod-pr-112 February 13, 2016 23:36 Active
MathieuNls added a commit that referenced this pull request Feb 13, 2016
New click-based synchronization system #58
@MathieuNls MathieuNls merged commit 1b0d805 into dev Feb 13, 2016
@MathieuNls MathieuNls deleted the 58_new_input branch February 15, 2016 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants