Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time on home and measure page #98

Closed
MathieuNls opened this issue Jan 7, 2016 · 5 comments
Closed

Add time on home and measure page #98

MathieuNls opened this issue Jan 7, 2016 · 5 comments
Assignees
@MathieuNls
Milestone
Tw 1.3

Comments

@MathieuNls
Copy link
Member

I suggest to add it also on the actual measure page, not only on the dashboard & home page.

time sur homepage
time sur measure page
@MathieuNls MathieuNls self-assigned this Jan 7, 2016
@MathieuNls MathieuNls added this to the Tw 1.3 milestone Jan 7, 2016
@MathieuNls
Copy link
Member Author

I've made some tests, the only place it really makes sense is on the dashboard.

MathieuNls added a commit that referenced this issue Jan 8, 2016
@MathieuNls
Adding time on dashboard #98
8e10db2 
Some users requested to have the time somewhere on the website so they could sync their timepieces. After some tests on the homepage and on the measure pages themself, it appears that the dashboard was the place to do that. @AlphonseJr : thoughts ?
MathieuNls added a commit that referenced this issue Jan 8, 2016
@MathieuNls
forgot one file #98
1dd50a7
@MathieuNls MathieuNls mentioned this issue Jan 8, 2016
Merged
MathieuNls added a commit that referenced this issue Jan 8, 2016
@MathieuNls
clean up css #98
7836fce
MathieuNls added a commit that referenced this issue Jan 8, 2016
@MathieuNls
add st,nd,rd,th to the day #98
978dc55
@AlphonseJr
Copy link
Collaborator

I'm not sure the rendering is right :

capture d ecran 2016-01-08 a 19 48 48

Why doesn't it make sense to have it also on the home ? Imo it would be great to have it on both :)

MathieuNls added a commit that referenced this issue Jan 8, 2016
@MathieuNls
Fix time css #98
e01b354
MathieuNls added a commit that referenced this issue Jan 8, 2016
@MathieuNls
remove 1s to the js watch so both time matches #98
ca32d68
@AlphonseJr
Copy link
Collaborator

Encore un petit soucis avec l'affichage

capture d ecran 2016-01-09 a 13 11 41

MathieuNls added a commit that referenced this issue Jan 9, 2016
@MathieuNls
Adding missing image for new moon #98
69d40fa
@MathieuNls
Copy link
Member Author

fixed

AlphonseJr added a commit that referenced this issue Jan 12, 2016
@AlphonseJr
Merge pull request #99 from MathieuNls/98_time
620377c 
Adding time on dashboard #98
@AlphonseJr
Copy link
Collaborator

Testé sur preprod : all good :)
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MathieuNls MathieuNls

Labels
None yet
Projects
None yet
Milestone
Tw 1.3
Development

No branches or pull requests
2 participants
@AlphonseJr @MathieuNls