Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Issue661Test.java #880

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Update Issue661Test.java #880

merged 1 commit into from
Apr 22, 2019

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Apr 14, 2019

Description

No not use the Outputstream to detect exceptions.

Related Issue

#877

Motivation and Context

Shitty test

How Has This Been Tested?

Locally run

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4
Update Issue661Test.java
b423f70 
No not use the Outputstream to detect exceptions.
@marci4 marci4 mentioned this pull request Apr 14, 2019
Open
4 tasks
@marci4 marci4 added this to the Release 1.4.1 milestone Apr 16, 2019
@marci4 marci4 merged commit 8a74a87 into TooTallNate:master Apr 22, 2019
@NoahAndrews NoahAndrews mentioned this pull request Aug 1, 2019
Closed
@marci4 marci4 removed the Bug label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahAndrews NoahAndrews NoahAndrews approved these changes

Assignees
No one assigned
Labels
Test
Projects
None yet
Milestone
Release 1.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@marci4 @NoahAndrews