3 issue tests fail

[NoahAndrews]

Describe the bug
Some tests fail on the master branch.

• 256
• 661
• 677 (5-10% of the time)
• 825

To Reproduce

1. Check out master branch
2. Run AllTests

Expected behavior
All tests should pass.

Environment(please complete the following information):

• Version used: master branch
• Java version: 1.8.0-191
• Operating System and version: Ubuntu 16.04

[marci4]

For me only 256 and 825 are failing.
I think 256 will be more stable when #347 is fixed.

Going to look into 825

Best regards,
Marcel

[NoahAndrews]

Test 677 also fails intermittently, indicating a race condition when closing a WebSocket. See this StackOverflow answer for an easy way to run the test repeatedly. For me it fails 5-10% of the time.

[NoahAndrews]

Test 661 was failing because the @Test annotation was commented out: java.lang.Exception: No runnable methods. Uncommenting the annotation results in the test failing due to java.net.BindException: Address already in use.

[marci4]

#880 fixes the test for 661.

[marci4]

Cannot reproduce Test825

[NoahAndrews]

You said you could before. Did it just stop failing for you?

[marci4]

Just updated my development branch... not sure, can you take a look at this?

[NoahAndrews]

It's just a naive test. It calls a non-blocking method to reconnect to the server on line 111, waits 100ms, assumes that the connection has been reestablished, and tries to send another message. With my setup, the reconnection actually takes somewhere between 100-200ms.

Issue #825 turned out to not even be any kind of bug in the library. My suggestion is to delete the test entirely.

[marci4]

@NoahAndrews better make it stable and maybe create a separate issue better matching the test.
I know the reason for #825 was the System.exit() but it is always good to have another test.

Best regards,
Marcel

[marci4]

825 should be more stable with #894 (350 runs without fail)