Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rf update mid april #8

Closed
wants to merge 3 commits into from
Closed

rf update mid april #8

wants to merge 3 commits into from

Conversation

dd0sxx
Copy link

@dd0sxx dd0sxx commented Apr 12, 2024

No description provided.

efecarranza
efecarranza reviewed Apr 12, 2024
View reviewed changes
src/20240412_AaveV2Polygon_ReserveFactorUpdates/AaveV2Polygon_ReserveFactorUpdates_20240412.sol Outdated
/**
* @title ReserveFactorUpdates
* @author TokenLogic
* - Discussion: https://governance.aave.com/t/arfc-reserve-factor-updates-polygon-aave-v2/13937/20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, need a new post on the forum with the new numbers and link to it here

...0240412_AaveV2Polygon_ReserveFactorUpdates/AaveV2Polygon_ReserveFactorUpdates_20240412.t.sol
/**
* @dev executes the generic test suite including e2e and config snapshots
*/
function test_defaultProposalExecution() public {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run to generate the diff file

src/20240412_AaveV2Polygon_ReserveFactorUpdates/ReserveFactorUpdates.md Outdated
---
title: "ReserveFactorUpdates"
author: "TokenLogic"
discussions: "https://governance.aave.com/t/arfc-reserve-factor-updates-polygon-aave-v2/13937/20"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update link to new post on forum

src/20240412_AaveV2Polygon_ReserveFactorUpdates/ReserveFactorUpdates.md Outdated Show resolved Hide resolved
@dd0sxx dd0sxx closed this Apr 29, 2024
Luigy-Lemon pushed a commit that referenced this pull request Jul 1, 2024
@miguelmtzinf @parth-15
Add AIP for GHO Cross-Chain Launch (bgd-labs#350)
7725647 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <[email protected]>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add AIP code

* fix: Fix AIP docs and imports

* fix: Remove unnecesary test

* fix: Updates risk params

* test: Add ccip e2e tests

* fix: Fix Arbitrum payload max bytecode size exceeded

* feat: Add sophisticated defensive aave seed (#13)

* feat: Add sophhisticated defensive aave seed

* fix: Allows AaveDefensive contract remove itself as facilitator

* fix: Add docs and reduce bytecode size

* fix: Reduce Utils lib bytecode size

* fix: Fix error in Utils

* fix: Add Capped gho usd price oracle

* fix: Add AIP draft text

* fix: Update block number for tests

* fix: Remove unneeded files

* fix: Install latest version of gho and ccip repos

* fix: Remove unused helper function

* fix: Fix AIP text

* fix: Remove defensive and use create2

* fix: Add fixed price oracle

* fix: Remove unnecessary memory variables

* fix: Use create1 and move listing out

* fix: Remove listing aip

---------

Co-authored-by: Parth Patel <[email protected]>
Luigy-Lemon pushed a commit that referenced this pull request Jul 1, 2024
@miguelmtzinf @parth-15
Fix GHO cross-chain AIP text (bgd-labs#360)
e0d12ee 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <[email protected]>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* fix: Fix AIP text

---------

Co-authored-by: Parth Patel <[email protected]>
Luigy-Lemon pushed a commit that referenced this pull request Jul 1, 2024
@miguelmtzinf @parth-15 @brotherlymite
Add second AIP for GHO Cross-Chain Launch (bgd-labs#356)
c7161d8 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <[email protected]>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: Add proposal to onboard GHO

* fix: Fix AIP name

* fix: Update GHO ir

* fix: Fix diff report

* fix: Fix typo in AIP text

Co-authored-by: Harsh Pandey <[email protected]>

* fix: Fix typo in AIP text

Co-authored-by: Harsh Pandey <[email protected]>

* fix: Fix tests

* fix: Fix lint

---------

Co-authored-by: Parth Patel <[email protected]>
Co-authored-by: Harsh Pandey <[email protected]>
efecarranza pushed a commit that referenced this pull request Jul 30, 2024
@CheyenneAtapour @parth-15
@miguelmtzinf @sendra
AIP: Events and Sponsorships Grant 2024 (bgd-labs#384)
ba24358 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <[email protected]>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* initial upload: proposal template and fund stream

* test: add stream withdraw test

* docs: add summary and specs of AIP

* test: add fuzz and insufficient funds tests

* test: fuzz by seconds instead of days

* fix: test changes as per pr comments

* fix: comment typo

* fix: discussion links, deal funds directly in tests

* feat: update proposal doc

* fix: doc header and formatting

* fix: replace arfc with aip

* fix: Fix typo in AIP text

Co-authored-by: sendra <[email protected]>

* feat: initial upload of template

* feat: initial upload doc

* fix: aip not arfc

* fix: Updates lib

* fix: Fix AIP text

---------

Co-authored-by: Parth Patel <[email protected]>
Co-authored-by: miguelmtzinf <[email protected]>
Co-authored-by: miguelmtz <[email protected]>
Co-authored-by: sendra <[email protected]>
LucasWongC pushed a commit that referenced this pull request Nov 25, 2024
@miguelmtzinf @parth-15
@DhairyaSethi @brotherlymite
GHO CCIP 1.5 Maintenance Upgrade (bgd-labs#512)
c016f11 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <[email protected]>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* feat: install aave-ccip at latest commit on aave/ccip#18

* chore: upd remappings, lib/aave-helpers, .assets

* new: add proposal for eth & arb

* fix: arb test supply locked invariant

* fix: rename, add discussion link

* upd: aave-ccip module

* feat: add proxy pool deployments

* feat: add e2e tests

* chore: fix license, explicit senders for expectEmit

* ci: override rpc url in secrets

* test: proxy pool can off ramp

* chore: reorder deps

* nit: utilize existing ierc20 import, style guide, use arb assets for gho addy

* feat: add rate limit, use gho fascilitator for tests

* feat: set in bound rate limit as well

* chore: cleanup

* test: check proxy initialized version

* chore: inBetween => inFlight"

* chore: test name consistency

* test: dynamically fetch dest gas amt

* test: execMsg post migration using legacy off ramp

* test: ccip steward can disable rate limit

* chore: cleanup

* doc: add comment for fetching all offramps, use RISK_COUNCIL for clarity

* test: ownership transfer after migration

* chore: rm _readRiskAdmin, fix config

* fix: ci test setup to stay compatible with bdg upstream

* feat: rm aave-ccip dep

* rft: use deployed token pools

* tmp: fix ci for aave org, to rm for bdg

* fix: ci to bdg setup

* fix: update rate limit

* test: fuzz amounts

* chore: snapshot docs

* chore: const cap rate

* chore: fix type

* fix: Fix rate limit config constants

* fix: tests, impl correct solc

* fix: tests

* Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Ethereum_GHOCCIP150Upgrade_20241021.sol

Co-authored-by: Harsh Pandey <[email protected]>

* Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021.sol

Co-authored-by: Harsh Pandey <[email protected]>

* doc: reference token pool contracts

* doc: upgrade spec

* doc: formatting

* Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md

Co-authored-by: miguelmtz <[email protected]>

* Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md

Co-authored-by: miguelmtz <[email protected]>

* test: Refresh block number with ghostewards aip executed

* fix: Remove unneeded script

---------

Co-authored-by: Parth Patel <[email protected]>
Co-authored-by: DhairyaSethi <[email protected]>
Co-authored-by: Harsh Pandey <[email protected]>
efecarranza pushed a commit that referenced this pull request Jan 20, 2025
@DhairyaSethi @parth-15
@miguelmtzinf @CanonicalJP
GHO CCIP 1.5.1 Upgrade Eth<>Arb (bgd-labs#557)
134c39c 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <[email protected]>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* chore: init aip

* feat: ccip 1.5.1 upgrade

* tmp: fix ci for aave org, to rm for bdg

* tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed

* tmp: fix ci for aave org

* revert: test ci secrets updates

* chore: fix comments

* chore: rm duplicate check

* chore: reorder imports, pending automation

* chore: import order

* chore: imports order, re-frame comment

* feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment

* chore: consistency, cleanup comment based on latest approach

* upd: `directMint` & `directBurn`

* feat: add `gho-core` lib temporarily, fix interface

* feat: new gho ccip steward

* feat: reference existing pool upgrade impl deployment

* feat: more verbose and efficient

* chore: upd ccip lib

* test: cleanup & fuzzify

* test: cleanup & fuzzify

* chore: use latest deployment of existing remote pool upgrade

* doc: snapshot -> direct-to-aip

* chore: import gho from EthereumAssets instead of MiscEthereum

* chore: cleanup rm ProxyAdmin reference

* chore: rename facilitator

* chore: rm duplicate check

* fix: updates based on upstream changes from bgd-labs#527

* chore: fix&add comment, use chain selector from helper lib

* chore: fix chain selector lib typo

* feat: accept existing proxy pool ownership as well

* feat: add rate limit

* feat: add deployed token pools & stewards

* feat: rm `gho-core` & `ccip`

* feat: upd arb token pool & steward deployment

* feat: notify gho bucket steward

* feat: update aave steward

* chore: use existing IOwnable

* chore: new ccip stewards with timelock getter

* feat: use oz v5.1 proxies

* doc: add discussion + spec

* feat: chainlink pre-req have been performed

* Updated GHOCCIP151Upgrade.md

* Updated GHOCCIP151Upgrade.md

Updated to permalinks

* doc: lint and add steward addresses to spec md

* doc: expand on bucket steward update

---------

Co-authored-by: Parth Patel <[email protected]>
Co-authored-by: miguelmtzinf <[email protected]>
Co-authored-by: miguelmtz <[email protected]>
Co-authored-by: JP <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efecarranza efecarranza efecarranza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dd0sxx @efecarranza