feat: optimizations #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luigy-Lemon
commented
Feb 14, 2024
Luigy-Lemon
commented
- Commented operations for better readibility.
- Reduced codesize of payload contract from 5788 to 5345 bytes
- Optimized execution and order of operations to save 2000 gas during execution.
- Commented operations for better readibility. - Reduced codesize of payload contract from 5788 to 5345 bytes - Optimized execution and order of operations to save 2000 gas during execution.
efecarranza
approved these changes
Feb 14, 2024
Luigy-Lemon
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: Add AIP code * fix: Fix AIP docs and imports * fix: Remove unnecesary test * fix: Updates risk params * test: Add ccip e2e tests * fix: Fix Arbitrum payload max bytecode size exceeded * feat: Add sophisticated defensive aave seed (#13) * feat: Add sophhisticated defensive aave seed * fix: Allows AaveDefensive contract remove itself as facilitator * fix: Add docs and reduce bytecode size * fix: Reduce Utils lib bytecode size * fix: Fix error in Utils * fix: Add Capped gho usd price oracle * fix: Add AIP draft text * fix: Update block number for tests * fix: Remove unneeded files * fix: Install latest version of gho and ccip repos * fix: Remove unused helper function * fix: Fix AIP text * fix: Remove defensive and use create2 * fix: Add fixed price oracle * fix: Remove unnecessary memory variables * fix: Use create1 and move listing out * fix: Remove listing aip --------- Co-authored-by: Parth Patel <[email protected]>
Luigy-Lemon
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * fix: Fix AIP text --------- Co-authored-by: Parth Patel <[email protected]>
Luigy-Lemon
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: Add proposal to onboard GHO * fix: Fix AIP name * fix: Update GHO ir * fix: Fix diff report * fix: Fix typo in AIP text Co-authored-by: Harsh Pandey <[email protected]> * fix: Fix typo in AIP text Co-authored-by: Harsh Pandey <[email protected]> * fix: Fix tests * fix: Fix lint --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: Harsh Pandey <[email protected]>
efecarranza
pushed a commit
that referenced
this pull request
Jul 30, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * initial upload: proposal template and fund stream * test: add stream withdraw test * docs: add summary and specs of AIP * test: add fuzz and insufficient funds tests * test: fuzz by seconds instead of days * fix: test changes as per pr comments * fix: comment typo * fix: discussion links, deal funds directly in tests * feat: update proposal doc * fix: doc header and formatting * fix: replace arfc with aip * fix: Fix typo in AIP text Co-authored-by: sendra <[email protected]> * feat: initial upload of template * feat: initial upload doc * fix: aip not arfc * fix: Updates lib * fix: Fix AIP text --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: miguelmtzinf <[email protected]> Co-authored-by: miguelmtz <[email protected]> Co-authored-by: sendra <[email protected]>
LucasWongC
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <[email protected]> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (#9) * fix: Remove unneeded diff file (#10) * feat: install aave-ccip at latest commit on aave/ccip#18 * chore: upd remappings, lib/aave-helpers, .assets * new: add proposal for eth & arb * fix: arb test supply locked invariant * fix: rename, add discussion link * upd: aave-ccip module * feat: add proxy pool deployments * feat: add e2e tests * chore: fix license, explicit senders for expectEmit * ci: override rpc url in secrets * test: proxy pool can off ramp * chore: reorder deps * nit: utilize existing ierc20 import, style guide, use arb assets for gho addy * feat: add rate limit, use gho fascilitator for tests * feat: set in bound rate limit as well * chore: cleanup * test: check proxy initialized version * chore: inBetween => inFlight" * chore: test name consistency * test: dynamically fetch dest gas amt * test: execMsg post migration using legacy off ramp * test: ccip steward can disable rate limit * chore: cleanup * doc: add comment for fetching all offramps, use RISK_COUNCIL for clarity * test: ownership transfer after migration * chore: rm _readRiskAdmin, fix config * fix: ci test setup to stay compatible with bdg upstream * feat: rm aave-ccip dep * rft: use deployed token pools * tmp: fix ci for aave org, to rm for bdg * fix: ci to bdg setup * fix: update rate limit * test: fuzz amounts * chore: snapshot docs * chore: const cap rate * chore: fix type * fix: Fix rate limit config constants * fix: tests, impl correct solc * fix: tests * Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Ethereum_GHOCCIP150Upgrade_20241021.sol Co-authored-by: Harsh Pandey <[email protected]> * Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021.sol Co-authored-by: Harsh Pandey <[email protected]> * doc: reference token pool contracts * doc: upgrade spec * doc: formatting * Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md Co-authored-by: miguelmtz <[email protected]> * Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md Co-authored-by: miguelmtz <[email protected]> * test: Refresh block number with ghostewards aip executed * fix: Remove unneeded script --------- Co-authored-by: Parth Patel <[email protected]> Co-authored-by: DhairyaSethi <[email protected]> Co-authored-by: Harsh Pandey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.