Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): implement the address resolution network struct functions #2773

Merged
merged 1 commit into from
Nov 28, 2024

feat: implement the last 2 missing network struct functions

ac81287
Select commit
Loading
Failed to load commit list.
Merged

feat(net): implement the address resolution network struct functions #2773

feat: implement the last 2 missing network struct functions
ac81287
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Nov 28, 2024 in 1s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : feat(net): implement the address resolution network struct functions
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : feat: implement the last 2 missing network struct functions
    and make use of them
    Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : - [x] implement getaddrinfo and freeaddrinfo
  • do we need stocktype/protocol?
  • replace all uses of getaddrinfo()
    • addr_resolve()
    • net_getipport()


This pr finally allows us to implement a regression test for #2361

Also allows fuzzing returned results from DNS.


This pr implements a different approach to disabling DNS, compared to #2694, here we can simply replace the functions pointers in the network object with dummies/stubs.


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}