forked from irungentoo/toxcore
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(net): implement the address resolution network struct functions #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
force-pushed
the
network_work1
branch
6 times, most recently
from
October 12, 2024 09:21
b13285b
to
992769c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2773 +/- ##
==========================================
+ Coverage 72.89% 73.21% +0.31%
==========================================
Files 149 149
Lines 30570 30595 +25
==========================================
+ Hits 22285 22401 +116
+ Misses 8285 8194 -91 ☔ View full report in Codecov by Sentry. |
Green-Sky
force-pushed
the
network_work1
branch
2 times, most recently
from
October 12, 2024 09:56
62852fe
to
b076947
Compare
Green-Sky
added
network
Network
bootstrap
Bootstrap
refactor
Refactoring production code, eg. renaming a variable, not affecting semantics
labels
Oct 12, 2024
Green-Sky
commented
Oct 12, 2024
Green-Sky
force-pushed
the
network_work1
branch
7 times, most recently
from
October 13, 2024 10:06
98d4d9b
to
23befb9
Compare
Green-Sky
changed the title
feat: implement the last 2 missing network struct functions
feat(net): implement the last 2 missing network struct functions
Oct 16, 2024
Green-Sky
force-pushed
the
network_work1
branch
2 times, most recently
from
October 16, 2024 10:14
726b2da
to
7fb9d41
Compare
iphydf
requested changes
Nov 9, 2024
Green-Sky
force-pushed
the
network_work1
branch
from
November 13, 2024 09:55
7fb9d41
to
12a2ee8
Compare
github-actions
bot
added
the
enhancement
New feature for the user, not a new feature for build script
label
Nov 13, 2024
iphydf
requested changes
Nov 27, 2024
pull-request-attention
bot
assigned Green-Sky and iphydf and unassigned iphydf and Green-Sky
Nov 27, 2024
Green-Sky
force-pushed
the
network_work1
branch
from
November 27, 2024 21:06
419d5b2
to
7f5c398
Compare
iphydf
reviewed
Nov 27, 2024
Green-Sky
force-pushed
the
network_work1
branch
5 times, most recently
from
November 27, 2024 22:36
23f7f96
to
916715f
Compare
Green-Sky
force-pushed
the
network_work1
branch
from
November 27, 2024 22:54
916715f
to
1a0aa4b
Compare
Green-Sky
commented
Nov 28, 2024
Green-Sky
force-pushed
the
network_work1
branch
2 times, most recently
from
November 28, 2024 11:42
3f2628d
to
81e1233
Compare
Green-Sky
changed the title
feat(net): implement the last 2 missing network struct functions
feat(net): implement the address resolution network struct functions
Nov 28, 2024
Green-Sky
force-pushed
the
network_work1
branch
2 times, most recently
from
November 28, 2024 14:04
c79b2f7
to
95a1596
Compare
iphydf
approved these changes
Nov 28, 2024
Green-Sky
force-pushed
the
network_work1
branch
3 times, most recently
from
November 28, 2024 15:07
956cd08
to
a16899d
Compare
and make use of them
Green-Sky
force-pushed
the
network_work1
branch
from
November 28, 2024 15:15
a16899d
to
ac81287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bootstrap
Bootstrap
enhancement
New feature for the user, not a new feature for build script
network
Network
refactor
Refactoring production code, eg. renaming a variable, not affecting semantics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getaddrinfo
andfreeaddrinfo
getaddrinfo()
addr_resolve()
net_getipport()
This pr finally allows us to implement a regression test for #2361
Also allows fuzzing returned results from DNS.
This pr implements a different approach to disabling DNS, compared to #2694, here we can simply replace the functions pointers in the network object with dummies/stubs.This change is