Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toxav rtp temp buffer allocation size was too large #2768

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Sep 17, 2024

and cast from 32bit to 16bit, causing a overflow and making the allocated size too small

supersedes #2766
fixes #2767

info copied from #2767 :

rdata_size here is 16bit, which gets cast from 32bit length, which can be much larger than the max representable of 16bit. BUT, rdata never contains more than a single packet, so why even try to allocate so much...


This change is Reviewable

@Green-Sky Green-Sky added this to the v0.2.20 milestone Sep 17, 2024
@Green-Sky Green-Sky added bug Bug fix for the user, not a fix to a build script toxav Audio/video labels Sep 17, 2024
@Green-Sky Green-Sky requested a review from a team as a code owner September 17, 2024 14:02
@Green-Sky Green-Sky force-pushed the fix_toxav_video_alloca branch 3 times, most recently from 234ccf3 to 2ed3990 Compare September 17, 2024 14:24
@zoff99 zoff99 self-requested a review September 17, 2024 15:10
@pull-request-attention pull-request-attention bot assigned Green-Sky and unassigned zoff99 Sep 17, 2024
and cast from 32bit to 16bit, causing a overflow and making the
allocated size too small
@Green-Sky Green-Sky force-pushed the fix_toxav_video_alloca branch from 2ed3990 to 671b1f9 Compare September 17, 2024 17:39
@Green-Sky Green-Sky merged commit 671b1f9 into TokTok:master Sep 17, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script toxav Audio/video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bringing light object to high resolution camera results in overflkow error
2 participants