fix: Limit memory allocation by MAX_CRYPTO_DATA_SIZE #2766
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix the issue, when shiny object is shown to the camera during the call. In this scenario camera creates big frames, for which toxcore tries to allocate memory and if the frame is big enough, it may fail, resulting in overflow error.
In this fix we limit the allocation size to
MAX_CRYPTO_DATA_SIZE
and, limit the frame size toUINT16_MAX
(we uselength_safe
instead oflength
variable).I have tested the fix on qTox client.
See issue
This change is