-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add a bin_unpack_bin_max
for max-length arrays.
#2415
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2415 +/- ##
==========================================
+ Coverage 74.47% 74.51% +0.03%
==========================================
Files 87 87
Lines 26189 26211 +22
==========================================
+ Hits 19505 19530 +25
+ Misses 6684 6681 -3
☔ View full report in Codecov by Sentry. |
1624044
to
4af8f08
Compare
5ab3972
to
ee05a1d
Compare
3b9e9f4
to
f755fcc
Compare
These are statically allocated (e.g. `uint8_t[1024]`) arrays with variable length data inside them. Examples are group topics and nicknames.
f755fcc
to
58fac53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained
These are statically allocated (e.g.
uint8_t[1024]
) arrays with variable length data inside them. Examples are group topics and nicknames.This change is