Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add a bin_unpack_bin_max for max-length arrays. #2415

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 7, 2023

These are statically allocated (e.g. uint8_t[1024]) arrays with variable length data inside them. Examples are group topics and nicknames.


This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Nov 7, 2023
@iphydf iphydf marked this pull request as draft November 7, 2023 17:54
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (d0304d8) 74.47% compared to head (e337837) 74.51%.
Report is 1 commits behind head on master.

❗ Current head e337837 differs from pull request most recent head 58fac53. Consider uploading reports for the commit 58fac53 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2415      +/-   ##
==========================================
+ Coverage   74.47%   74.51%   +0.03%     
==========================================
  Files          87       87              
  Lines       26189    26211      +22     
==========================================
+ Hits        19505    19530      +25     
+ Misses       6684     6681       -3     
Files Coverage Δ
toxcore/events/friend_connection_status.c 82.14% <100.00%> (ø)
toxcore/events/friend_message.c 81.73% <100.00%> (ø)
toxcore/events/friend_name.c 76.84% <100.00%> (ø)
toxcore/events/friend_status.c 81.92% <100.00%> (ø)
toxcore/events/friend_status_message.c 77.08% <100.00%> (ø)
toxcore/events/friend_typing.c 81.92% <100.00%> (ø)
toxcore/network.c 86.09% <100.00%> (ø)
toxcore/bin_unpack.c 78.43% <91.66%> (+1.01%) ⬆️
toxcore/events/conference_invite.c 14.42% <0.00%> (ø)
toxcore/events/conference_message.c 13.27% <0.00%> (ø)
... and 14 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the bin-unpack-max branch 5 times, most recently from 1624044 to 4af8f08 Compare November 11, 2023 04:30
@iphydf iphydf marked this pull request as ready for review November 11, 2023 04:30
@iphydf iphydf force-pushed the bin-unpack-max branch 3 times, most recently from 5ab3972 to ee05a1d Compare November 11, 2023 04:47
@iphydf iphydf requested a review from JFreegman November 11, 2023 04:48
@iphydf iphydf force-pushed the bin-unpack-max branch 2 times, most recently from 3b9e9f4 to f755fcc Compare November 12, 2023 00:55
These are statically allocated (e.g. `uint8_t[1024]`) arrays with
variable length data inside them. Examples are group topics and
nicknames.
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@pull-request-attention pull-request-attention bot assigned iphydf and unassigned JFreegman Nov 12, 2023
@iphydf iphydf merged commit 58fac53 into TokTok:master Nov 12, 2023
35 checks passed
@iphydf iphydf deleted the bin-unpack-max branch November 12, 2023 06:06
@Green-Sky Green-Sky mentioned this pull request Nov 13, 2023
Green-Sky added a commit to Green-Sky/c-toxcore that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants