Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ngc Events #2378

Closed
wants to merge 1 commit into from
Closed

feat: add ngc Events #2378

wants to merge 1 commit into from

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Mar 29, 2023 •
edited by iphydf
Loading

most lines where autogenerated

This change is Reviewable

@Green-Sky Green-Sky marked this pull request as draft March 29, 2023 00:42
@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Attention: 1688 lines in your changes are missing coverage. Please review.

Comparison is base (2b0dc0f) 69.81% compared to head (dfbe28b) 70.37%.
Report is 12 commits behind head on master.

❗ Current head dfbe28b differs from pull request most recent head e29e185. Consider uploading reports for the commit e29e185 to get more accurate results

Files Patch % Lines
toxcore/events/group_peer_exit.c 10.86% 123 Missing ⚠️
toxcore/events/group_message.c 12.00% 110 Missing ⚠️
toxcore/events/group_invite.c 12.50% 105 Missing ⚠️
toxcore/events/group_private_message.c 12.93% 101 Missing ⚠️
toxcore/events/group_custom_packet.c 14.01% 92 Missing ⚠️
toxcore/events/group_custom_private_packet.c 14.01% 92 Missing ⚠️
toxcore/events/group_peer_name.c 14.01% 92 Missing ⚠️
toxcore/events/group_topic.c 14.01% 92 Missing ⚠️
toxcore/tox_dispatch.c 44.44% 90 Missing ⚠️
toxcore/events/group_moderation.c 14.42% 89 Missing ⚠️
... and 11 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2378      +/-   ##
==========================================
+ Coverage   69.81%   70.37%   +0.55%     
==========================================
  Files          75      105      +30     
  Lines       25964    28345    +2381     
==========================================
+ Hits        18127    19947    +1820     
- Misses       7837     8398     +561

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Green-Sky Green-Sky force-pushed the ngc_events branch 2 times, most recently from e56cb16 to e0e41ed Compare March 29, 2023 12:51
@Green-Sky Green-Sky changed the title events: add ngc events feat: ngc events Mar 29, 2023
@Green-Sky Green-Sky marked this pull request as ready for review March 29, 2023 14:50
@Tha14
Copy link

Tha14 commented Mar 29, 2023 •
edited
Loading

Fuzzers seem to work good to me when I run them locally.

@Green-Sky
Copy link
Member Author

had the event_fuzzer running for a while

#766218921	REDUCE cov: 1218 ft: 3344 corp: 1236/129Kb lim: 4096 exec/s: 83776 rss: 633Mb L: 332/3848 MS: 2 InsertByte-EraseBytes-
#766645022	REDUCE cov: 1218 ft: 3344 corp: 1236/129Kb lim: 4096 exec/s: 83777 rss: 633Mb L: 435/3848 MS: 1 EraseBytes-
#767340340	REDUCE cov: 1218 ft: 3344 corp: 1236/129Kb lim: 4096 exec/s: 83770 rss: 633Mb L: 255/3848 MS: 1 EraseBytes-
#768279758	REDUCE cov: 1218 ft: 3344 corp: 1236/129Kb lim: 4096 exec/s: 83754 rss: 633Mb L: 77/3848 MS: 2 ChangeASCIIInt-EraseBytes-
#768588187	REDUCE cov: 1218 ft: 3344 corp: 1236/129Kb lim: 4096 exec/s: 83751 rss: 633Mb L: 328/3848 MS: 1 EraseBytes-
#768703483	REDUCE cov: 1218 ft: 3344 corp: 1236/129Kb lim: 4096 exec/s: 83745 rss: 633Mb L: 410/3848 MS: 1 EraseBytes-
#768810329	REDUCE cov: 1218 ft: 3344 corp: 1236/129Kb lim: 4096 exec/s: 83748 rss: 633Mb L: 176/3848 MS: 3 EraseBytes-ChangeByte-PersAutoDict- DE: "\x00%"-
#768845221	REDUCE cov: 1218 ft: 3344 corp: 1236/129Kb lim: 4096 exec/s: 83743 rss: 633Mb L: 163/3848 MS: 2 ShuffleBytes-EraseBytes-
==2693886== libFuzzer: run interrupted; exiting

@JFreegman JFreegman added the enhancement New feature for the user, not a new feature for build script label Mar 31, 2023
@JFreegman JFreegman added this to the v0.2.19 milestone Mar 31, 2023
JFreegman
JFreegman reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is too massive to review line by line. We need some autotests for it.

Reviewed 32 of 32 files at r1, all commit messages.
Reviewable status: 0 of 1 approvals obtained

@Green-Sky Green-Sky mentioned this pull request Aug 22, 2023
Merged
@Green-Sky Green-Sky changed the title feat: ngc events feat: add ngc Events Aug 22, 2023
@Green-Sky Green-Sky modified the milestones: v0.2.19, v0.2.20 Nov 10, 2023
@iphydf iphydf modified the milestones: v0.2.20, v0.2.19 Nov 11, 2023
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Nov 11, 2023
@Green-Sky
Copy link
Member Author

Green-Sky commented Nov 13, 2023 •
edited
Loading

done.
note to self: need to adopt to changes made in #2415

@Green-Sky Green-Sky force-pushed the ngc_events branch 2 times, most recently from 3f5a0a4 to d4b06ed Compare November 17, 2023 14:51
@Green-Sky Green-Sky mentioned this pull request Dec 19, 2023
Merged
@Green-Sky Green-Sky force-pushed the ngc_events branch 5 times, most recently from cd0b858 to fcbf840 Compare December 23, 2023 19:31
@Green-Sky Green-Sky mentioned this pull request Dec 25, 2023
Merged
1 task
@Green-Sky
Copy link
Member Author

updated version merged into #2392

@Green-Sky Green-Sky closed this Dec 25, 2023
@iphydf iphydf modified the milestones: v0.2.20, v0.2.19 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFreegman JFreegman JFreegman left review comments

Assignees

@Green-Sky Green-Sky

Labels
enhancement New feature for the user, not a new feature for build script
Projects
DHT Group Chats
Status: Done
Milestone
v0.2.19
Development

Successfully merging this pull request may close these issues.
4 participants
@Green-Sky @Tha14 @JFreegman @iphydf