fix: Add workaround for issue when image is created with "docker commit"

[Tiryoh]

Add workaround for issue when image is created with "docker commit"

Thanks @SaadRana17!

#131 (comment)

Summary by CodeRabbit

• Bug Fixes

  • Implemented workarounds for issues related to Docker image creation using "docker commit."
  • Removed lock files before starting VNC server to prevent related issues.

• Improvements

  • Removed outdated notes about logging out before stopping to commit a Docker container.
  • Added a note about the security-opt flag requirement for launching the Ubuntu Jammy-based image.

[coderabbitai]

Walkthrough

The updates to the entrypoint.sh scripts across multiple versions (foxy, humble, iron, jazzy) incorporate a workaround for an issue related to Docker image creation using the "docker commit" command. The scripts now include logic to check for and remove certain lock files before starting the VNC server and have removed previous notes advising users to log out before committing a Docker container. Additionally, the iron script notes the security-opt flag requirement for Ubuntu Jammy.

Changes

File	Change Summary
foxy/entrypoint.sh	Added Docker commit workaround, removed specific lock files, adjusted comments and keywords.
humble/entrypoint.sh	Added Docker commit workaround, included lock file removal, removed log-out note.
iron/entrypoint.sh	Added Docker commit workaround, included lock file removal, added note on security-opt flag for Ubuntu Jammy, removed log-out note.
jazzy/entrypoint.sh	Added Docker commit workaround, removed log-out note.

Poem

🐰 Amidst the lines of code so vast,

We’ve crafted scripts to hold steadfast.

Lock files now swiftly disappear,

Docker commits have nothing to fear.

Foxy, Humble, Iron, Jazzy—oh so fast!

Onward, we make solutions ever so clear. 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ed5db33 and d9ef6f6.

Files selected for processing (4)

• foxy/entrypoint.sh (4 hunks)
• humble/entrypoint.sh (2 hunks)
• iron/entrypoint.sh (2 hunks)
• jazzy/entrypoint.sh (2 hunks)

Files skipped from review due to trivial changes (2)

• foxy/entrypoint.sh
• humble/entrypoint.sh

Additional comments not posted (2)

iron/entrypoint.sh (1)

45-54: Approve workaround for Docker commit issue.

The added script correctly checks for and removes the /tmp/.X1-lock and /tmp/.X11-unix/X1 files, which can prevent the VNC server from starting correctly if left behind after improper shutdowns. This is a well-known issue in Docker environments where the X server is involved.

jazzy/entrypoint.sh (1)

45-54: Approve identical workaround for Docker commit issue in Jazzy environment.

The same workaround applied in the iron environment is correctly replicated here for the jazzy environment. This ensures consistency across different Docker environments and addresses the same issue of lock files preventing the VNC server from starting.