Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal length limit on URIs. #1288

Merged
merged 1 commit into from
May 29, 2019
Merged

Remove internal length limit on URIs. #1288

merged 1 commit into from
May 29, 2019

Conversation

tdenniston
Copy link
Contributor

@tdenniston tdenniston commented May 29, 2019 •
edited
Loading

Closes #1285. Also closes #1175.

@tdenniston tdenniston added this to the 1.6.0 milestone May 29, 2019
@tdenniston tdenniston requested a review from jakebolewski May 29, 2019 19:04
@tdenniston
Copy link
Contributor Author

Some posix/ext4 error messages look like this:

[2019-05-29 15:14:17.319] [tiledb] [Process: 66868] [Thread: 3031887] [error] [TileDB::IO] Error: Failed to create file '/Users/tyler/tiledb/TileDB/cmake-build-debug-serialization/test/tiledb_test/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'; File name too long

Some Windows error messages look like this:

2019-05-29T17:46:38.2833480Z   1: [2019-05-29 17:46:38.282] [tiledb] [Process: 2348] [Thread: 3124] [error] [TileDB::IO] Error: Cannot create directory 'D:\a\1\s\test\tiledb_test\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\subdir\': The filename or extension is too long.```

@tdenniston tdenniston merged commit 593886f into dev May 29, 2019
@tdenniston tdenniston deleted the ttd/1285 branch May 29, 2019 20:12
@tdenniston tdenniston modified the milestones: 1.6.0, 1.5.2 May 30, 2019
@tdenniston tdenniston added the backport tags commits to backport to release branch label May 30, 2019
tdenniston added a commit that referenced this pull request Jun 3, 2019
@tdenniston
Remove internal length limit on URIs.
98a38c2 
Closes #1285.

PR #1288

(cherry picked from commit 036b910)
@tdenniston tdenniston removed the backport tags commits to backport to release branch label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebolewski jakebolewski jakebolewski approved these changes

Assignees
No one assigned
Labels
internals
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.

Remove internal length limits for URIs Too long path names not properly diagnosed
2 participants
@tdenniston @jakebolewski