Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal length limits for URIs #1285

Closed
tdenniston opened this issue May 29, 2019 · 1 comment · Fixed by #1288
Closed

Remove internal length limits for URIs #1285

tdenniston opened this issue May 29, 2019 · 1 comment · Fixed by #1288

Comments

@tdenniston
Copy link
Contributor

Currently we enforce a limit of 256 chars for the total length of URIs, which was originally intended to improve cross-filesystem compatibility.

However, this is a fairly restrictive limit and ultimately I don't think it should be TileDB's responsibility to enforce this: the limit should depend on and be enforced by the underlying filesystem/object store. Instead, we should allow long URIs internally, and properly propagate any underlying filesystem errors. E.g. on ext4 when creating a filename that is too long:

ubuntu@ip-172-31-35-56:~$ touch xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
ubuntu@ip-172-31-35-56:~$ touch yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy
touch: cannot touch 'yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy': File name too long

we should just propagate the File name too long message on our error path.

@ihnorton
Copy link
Member

related to #1175

tdenniston added a commit that referenced this issue May 29, 2019
tdenniston added a commit that referenced this issue May 29, 2019
tdenniston added a commit that referenced this issue May 29, 2019
tdenniston added a commit that referenced this issue Jun 3, 2019
Closes #1285.

PR #1288

(cherry picked from commit 036b910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants