Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You wouldnt pirate a type #118

Merged
merged 33 commits into from
Sep 17, 2024
Merged

You wouldnt pirate a type #118

merged 33 commits into from
Sep 17, 2024

Conversation

rdboyes
Copy link
Member

@rdboyes rdboyes commented Sep 17, 2024 •
edited
Loading

Massive refactor.

Adds:

  • calculations in @aes macro
  • broadcasting support
  • fill scales (not complete)
  • ggsave for GGPlotGrids

Removes:

  • All type piracy
  • A lot of complexity from the calculation system (now handled entirely by DataFrames.jl)

closes #71
closes #100
closes #108
closes #97

rdboyes added 30 commits June 27, 2024 11:00
@rdboyes
edit Readme with desired functionality
8570c5b
@rdboyes
version bump
0541eaa
@rdboyes
remove type piracy
ea77d86
@rdboyes
edit tests to reflect new syntax
b29e573
@rdboyes
edits to aes macro to allow function parsing
3a90186
@rdboyes
nuke the entire concept of an AesTransform
cd28763
@rdboyes
add function application to draw.jl
f0f36c2
@rdboyes
removing references to AesTransforms
f8cc571
@rdboyes
fixing types
45a102f
@rdboyes
adds broadcasting
98fe1a9
@rdboyes
add support for broadcasting plots
6d5d7f6
@rdboyes
rebuild aes constructors to fix macro version
3de1b59
@rdboyes
refactor draw
f4b0f26
@rdboyes
temporarily remove geom_contour
48bcaee
@rdboyes
remove transformations interface
0f6b1dd
@rdboyes
remove references to transformation interface
993f469
@rdboyes
add support for ggplotGrid in the other ggsave variant
df6773a
@rdboyes
bumpm version to 0.8.0 because of breaking changes
a40276f
@rdboyes
tear out grouping and facet machinery
a9f98b4
@rdboyes
missed a couple of transforms
bdc33a0
@rdboyes
128 passing tests, up from zero
71aed88
@rdboyes
with col transforms removed, need to split aes_function into a pre an…
2b87799 
…d post function
@rdboyes
130 passing tests
7262384
@rdboyes
140 passing tests
419fe46
@rdboyes
141 tests passing
76b322e
@rdboyes
143 passing
9ab6338
@rdboyes
two steps forward, one step back (135 passing)
ce67cd4
@rdboyes
144 tests passing (numeric scales fixed)
993ac71
@rdboyes
148 passing, color scales fixed
badde45
@rdboyes
errorbar fixed
e3db606
@rdboyes rdboyes merged commit a8c6589 into main Sep 17, 2024
3 of 4 checks passed
@rdboyes rdboyes deleted the you-wouldnt-pirate-a-type branch September 17, 2024 19:10
@rdboyes rdboyes mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@rdboyes