Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Default gateway visibility not updating in Packet Broker view #6719

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Fix Default gateway visibility not updating in Packet Broker view #6719

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0ef919
console: Add request
ryaplots Nov 22, 2023
5883331
console: Make request in admin-packet-broker.js
ryaplots Nov 23, 2023
2c58599
Revert "console: Make request in admin-packet-broker.js"
ryaplots Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions pkg/webui/console/views/admin-packet-broker/default-gateway-visibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,16 @@ import { useSelector, useDispatch } from 'react-redux'
import toast from '@ttn-lw/components/toast'

import Message from '@ttn-lw/lib/components/message'
import RequireRequest from '@ttn-lw/lib/components/require-request'

import GatewayVisibilityForm from '@console/components/gateway-visibility-form'

import attachPromise from '@ttn-lw/lib/store/actions/attach-promise'

import { setHomeNetworkDefaultGatewayVisibility } from '@console/store/actions/packet-broker'
import {
getHomeNetworkDefaultGatewayVisibility,
setHomeNetworkDefaultGatewayVisibility,
} from '@console/store/actions/packet-broker'

import { selectHomeNetworkDefaultGatewayVisibility } from '@console/store/selectors/packet-broker'

Expand Down Expand Up @@ -55,18 +59,20 @@ const DefaultGatewayVisibilityView = () => {
)

return (
<Col md={12}>
<Message
content={m.gatewayVisibilityInformation}
component="p"
className={style.routingPolicyInformation}
/>
<GatewayVisibilityForm
onSubmit={handleDefaultGatewayVisibilitySubmit}
initialValues={initialValues}
error={formError}
/>
</Col>
<RequireRequest requestAction={getHomeNetworkDefaultGatewayVisibility()}>
ryaplots marked this conversation as resolved.
Show resolved Hide resolved
<Col md={12}>
<Message
content={m.gatewayVisibilityInformation}
component="p"
className={style.routingPolicyInformation}
/>
<GatewayVisibilityForm
onSubmit={handleDefaultGatewayVisibilitySubmit}
initialValues={initialValues}
error={formError}
/>
</Col>
</RequireRequest>
)
}

Expand Down
Loading