Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Default gateway visibility not updating in Packet Broker view #6719

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Fix Default gateway visibility not updating in Packet Broker view #6719

merged 3 commits into from
Nov 23, 2023

Conversation

ryaplots
Copy link
Contributor

Summary

This PR fixes https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1006#issuecomment-1822860616

Changes

  • Add <RequireRequest /> in Gateway Visibility view

Testing

  1. Log into the Console
  2. Go to Admin Panel -> Peering settings -> Default gateway visibility
  3. Make changes and save them
  4. Refresh the page and see that the changes persist

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Nov 22, 2023
@ryaplots ryaplots added this to the v3.28.2 milestone Nov 22, 2023
@ryaplots ryaplots self-assigned this Nov 22, 2023
@ryaplots ryaplots requested a review from a team as a code owner November 23, 2023 10:00
@ryaplots ryaplots requested a review from kschiffer November 23, 2023 10:00
@ryaplots ryaplots merged commit 83f0086 into v3.28 Nov 23, 2023
9 of 10 checks passed
@ryaplots ryaplots deleted the fix/default-gateway-visibility branch November 23, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton

@PavelJankoski PavelJankoski Awaiting requested review from PavelJankoski

Assignees

@ryaplots ryaplots

Labels
ui/web This is related to a web interface
Projects
None yet
Milestone
v3.28.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ryaplots @kschiffer