Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gateway Stats Batch API in the Console #6689

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

PavelJankoski
Copy link
Contributor

Summary

Closes #5635

Changes

When fetching gateways we were sending a request for every gateway. Now we send only one request for the loaded gateways.

Testing

  1. Login in the console.
  2. Go to /console/gateways page.
  3. Check if the gateways have the correct status.
  4. Check in developers console in Network tab if we are sending only one request related to the stats.

Notes for Reviewers

In the gateway details page we are still using the old endpoint but we are sending one request anyway. That's the reason I didn't consider changing it.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added c/console This is related to the Console ui/web This is related to a web interface labels Nov 8, 2023
@PavelJankoski PavelJankoski added this to the v3.28.1 milestone Nov 8, 2023
@PavelJankoski PavelJankoski self-assigned this Nov 8, 2023
@github-actions github-actions bot removed the c/console This is related to the Console label Nov 8, 2023
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PavelJankoski PavelJankoski merged commit c2a9417 into v3.28 Nov 9, 2023
12 of 13 checks passed
@PavelJankoski PavelJankoski deleted the feature/5635-stats-batch-api branch November 9, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Gateway Stats Batch API in the Console
3 participants