Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gateway Stats Batch API in the Console #5635

Closed
2 of 4 tasks
KrishnaIyer opened this issue Jul 22, 2022 · 3 comments · Fixed by #6689
Closed
2 of 4 tasks

Use Gateway Stats Batch API in the Console #5635

KrishnaIyer opened this issue Jul 22, 2022 · 3 comments · Fixed by #6689
Assignees
Labels
c/console This is related to the Console ui/web This is related to a web interface
Milestone

Comments

@KrishnaIyer
Copy link
Member

Summary

Use Gateway Stats Batch API in the Console.

Current Situation

Clients (including the console) today use the GetGatewayConnectionStats (and it's HTTP end point) to fetch stats for a single gateway.

With #5536 we now support a new BatchGetGatewayConnectionStats end point that can retrieve the connection stats for a batch of gateways in a single call.

Why do we need this? Who uses it, and when?

Switching to the new BatchGetGatewayConnectionStats RPC will drastically reduce the API calls made (esp) by the console to TTS.

Proposed Implementation

Use BatchGetGatewayConnectionStats (/gs/gateways/connection/stats HTTP end point) and post the list of gateway IDs.

Make sure to check the gateway_server_address of each gateway, collect gateways that have a common address (cluster) and send the request to the GS of that address (cluster).

Contributing

  • I can help by doing more research.
  • I can help by implementing the feature after the proposal above is approved.
  • I can help by testing the feature before it's released.

Code of Conduct

@KrishnaIyer KrishnaIyer added the needs/triage We still need to triage this label Jul 22, 2022
@KrishnaIyer
Copy link
Member Author

Assigning @kschiffer for triaging.

@NicolasMrad NicolasMrad added this to the 2022 Q3 milestone Jul 25, 2022
@NicolasMrad NicolasMrad removed the needs/triage We still need to triage this label Jul 25, 2022
@kschiffer kschiffer added c/console This is related to the Console ui/web This is related to a web interface labels Sep 13, 2022
@kschiffer kschiffer modified the milestones: 2022 Q3, v3.22.0 Sep 13, 2022
@NicolasMrad NicolasMrad modified the milestones: v3.22.0, 2022 Q4 Sep 27, 2022
@NicolasMrad NicolasMrad modified the milestones: 2022 Q4, 2023 Q1 Jan 2, 2023
@NicolasMrad NicolasMrad modified the milestones: 2023 Q1, 2023 Q2 Apr 12, 2023
@KrishnaIyer
Copy link
Member Author

Let's hold this on https://github.com/TheThingsIndustries/product-management/issues/6, which introduces batch rights checks.

@KrishnaIyer KrishnaIyer added the blocked This can't continue until another issue or pull request is done label Jul 4, 2023
@KrishnaIyer KrishnaIyer modified the milestones: 2023 Q2, Q3 2023 Jul 4, 2023
@KrishnaIyer KrishnaIyer modified the milestones: 2023 Q3, Sep 2023 Aug 9, 2023
@KrishnaIyer KrishnaIyer removed the blocked This can't continue until another issue or pull request is done label Sep 27, 2023
@KrishnaIyer KrishnaIyer modified the milestones: Sep 2023, v3.28.1 Sep 27, 2023
@KrishnaIyer
Copy link
Member Author

Reassigning this for this milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants