-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPC to batch retrieve gateway connection stats #5536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c/gateway server
This is related to the Gateway Server
compat/api
This could affect API compatibility
compat/db
This could affect Database compatibility
ui/cli
This is related to ttn-lw-cli
labels
Jun 15, 2022
KrishnaIyer
force-pushed
the
feature/5398-batch-retrieval
branch
3 times, most recently
from
July 11, 2022 09:56
7a5d114
to
415576a
Compare
KrishnaIyer
requested review from
johanstokking,
adriansmares and
htdvisser
as code owners
July 11, 2022 11:06
KrishnaIyer
force-pushed
the
feature/5398-batch-retrieval
branch
from
July 12, 2022 07:11
415576a
to
f10ca88
Compare
adriansmares
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, now it is really clean.
KrishnaIyer
force-pushed
the
feature/5398-batch-retrieval
branch
from
July 12, 2022 09:11
f2e5577
to
6f852c3
Compare
htdvisser
reviewed
Jul 13, 2022
KrishnaIyer
force-pushed
the
feature/5398-batch-retrieval
branch
from
July 13, 2022 07:53
73fe929
to
7624cd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but few questions
KrishnaIyer
force-pushed
the
feature/5398-batch-retrieval
branch
from
July 13, 2022 12:52
7624cd0
to
abb4508
Compare
KrishnaIyer
commented
Jul 13, 2022
KrishnaIyer
force-pushed
the
feature/5398-batch-retrieval
branch
from
July 13, 2022 13:19
ae2133c
to
f4d2055
Compare
htdvisser
reviewed
Jul 13, 2022
Test for CLI Combinations
|
KrishnaIyer
force-pushed
the
feature/5398-batch-retrieval
branch
from
July 18, 2022 14:50
b6434fa
to
37349ef
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c/gateway server
This is related to the Gateway Server
c/identity server
This is related to the Identity Server
compat/api
This could affect API compatibility
compat/db
This could affect Database compatibility
ui/cli
This is related to ttn-lw-cli
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5398
Changes
BatchGetGatewayConnectionStats
.Testing
Regressions
Possible regression in
get-connection-stats
CLI command. Test case 7 covers this.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.