-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set location metadata in uplink messages forwarded by the AS #3294
Conversation
Blocked by #3293 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Target your cache PR in order to distinguish the changes.
Lots of reviewers here; @neoaggelos who should do what? |
This is because of CODEOWNERS. This PR is currently blocked waiting for #3293 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I like the high coupling in AS this way. For inspiration, please see the tenant fetcher which has a cache.
You might want to change the cache interface to a generic "getter" with callback to fetch the entity if needed. The concrete implementation can then always use the callback to get the entity (no cache), use a memory cache, etc.
Wait, is #3293 the better version of this? |
#3294 (comment). #3293 is the device fetcher extracted as a separate PR, so that this can focus on the proto changes instead. |
If you make such chains of PRs, please actually make them target one another instead of making it look like this PR introduces changes that it doesn't. While you indeed added the If you would have targeted your branch from #3293 here, instead of GitHub would have also automatically changed the target of this branch back to |
6df9e8e
to
823eb1a
Compare
823eb1a
to
9d44c8a
Compare
8ddae1e
to
691d771
Compare
Summary
Closes #2669
Changes
locations
field inApplicationUplink
messages.Testing
Notes for Reviewers
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.