Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Document uplink message consumed airtime and location fields #9

Merged
merged 1 commit into from
Oct 13, 2020
Merged

doc: Document uplink message consumed airtime and location fields #9

merged 1 commit into from
Oct 13, 2020

Conversation

neoaggelos
Copy link
Contributor

@neoaggelos neoaggelos commented Sep 30, 2020 •
edited
Loading

Summary

Accompanying doc changes for TheThingsNetwork/lorawan-stack#3298 and TheThingsNetwork/lorawan-stack#3294

Changes

  • Add consumed_airtime field in data formats
  • Add consumed_airtime in MQTT API comparison between v2 and v3.

Notes for Reviewers

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in README.md.
  • Style Guidelines: Documentation obeys style guidelines in README.md.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@neoaggelos neoaggelos self-assigned this Sep 30, 2020
@neoaggelos neoaggelos requested a review from benolayinka October 2, 2020 07:07
@neoaggelos neoaggelos added this to the October 2020 milestone Oct 2, 2020
@neoaggelos
Copy link
Contributor Author

TheThingsNetwork/lorawan-stack#3298 has been merged, so this is ready for review

@neoaggelos neoaggelos changed the title doc: Document uplink message consumed airtime field doc: Document uplink message consumed airtime and location fields Oct 8, 2020
@neoaggelos neoaggelos force-pushed the consumed-uplink-airtime branch from 4b5979f to 247318a Compare October 8, 2020 23:39
@neoaggelos neoaggelos force-pushed the consumed-uplink-airtime branch from 247318a to 3863a43 Compare October 13, 2020 05:12
@neoaggelos neoaggelos merged commit 56aafc8 into master Oct 13, 2020
@benolayinka benolayinka deleted the consumed-uplink-airtime branch December 21, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benolayinka benolayinka benolayinka approved these changes

Assignees

@neoaggelos neoaggelos

Labels
c/application server c/network server
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@neoaggelos @benolayinka