Add makerfabs #844
Merged
Add makerfabs #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooper99-ui
requested review from
Jaime-Trinidad and
johanstokking
as code owners
|
|
|
Thanks @cooper99-ui. This diff is too large. At first glance, the file permissions are changed for a lot of files, leading to a massive diff. Also there are formatting changes in I would assume only |
|
Dear Johan Stokking:
I am very happy to receive your reply. Since this is the first time for me to deal with this matter, there may be many mistakes. I am very sorry for that. In fact, I only added the product file of our company and did not change other files. I did this in a Linux virtual machine environment, I don't know if this has any effect, because I watched the instructional video in a mac environment, the current situation is that I should start again or there is another solution. Looking forward to your reply again
copper
***@***.***
From: Johan Stokking
Date: 2024-11-07 16:45
To: TheThingsNetwork/lorawan-devices
CC: cooper99-ui; Mention
Subject: Re: [TheThingsNetwork/lorawan-devices] Add makerfabs (PR #844)
Thanks @cooper99-ui. This diff is too large. At first glance, the file permissions are changed for a lot of files, leading to a massive diff. Also there are formatting changes in bin/validate.js. See https://github.com/TheThingsNetwork/lorawan-devices/pull/844/files. We only expect changed files there.
I would assume only vendor/makerfabs would be added and the vendor to be added to vendor/index.yaml. If you need help, let us know.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@cooper99-ui I think I fixed this for you. Can you check the change set here please? |
|
hi,Johan Stokking
I have seen the changed part, which is the file I added. Thank you very much for your help. I have more than ten products to add to the repository later, do you think it is OK to operate like this product? Looking forward to your reply again
cooper
***@***.***
From: Johan Stokking
Date: 2024-11-07 23:31
To: TheThingsNetwork/lorawan-devices
CC: cooper99-ui; Mention
Subject: Re: [TheThingsNetwork/lorawan-devices] Add makerfabs (PR #844)
@cooper99-ui I think I fixed this for you. Can you check the change set here please?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This product looks good, the codec too. I would rename the product name next time, it's all lowercase now. The issue is likely caused by a code editor and/or file formatter. Best is to disable those. |
|
hi,Johan Stokking, I have seen my product added to the repository, but I don't see our product optional on the ttn product selection page, do we need to wait for some time to see it? Now we want to see the display effect of this product first, and then we plan to add our next dozen products to the repository, we are looking forward to your reply again
***@***.***
From: Johan Stokking
Date: 2024-11-08 17:26
To: TheThingsNetwork/lorawan-devices
CC: cooper99-ui; Mention
Subject: Re: [TheThingsNetwork/lorawan-devices] Add makerfabs (PR #844)
hi,Johan Stokking I have seen the changed part, which is the file I added. Thank you very much for your help. I have more than ten products to add to the repository later, do you think it is OK to operate like this product? Looking forward to your reply again cooper
This product looks good, the codec too. I would rename the product name next time, it's all lowercase now.
The issue is likely caused by a code editor and/or file formatter. Best is to disable those.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@cooper99-ui it is listed here: https://www.thethingsnetwork.org/device-repository/devices/makerfabs/ath20/. In The Things Stack, it will be part of the next release. |
|
Hello,Johan Stokking,
Is it okay if I add the rest of my products to the repository, look forward to your recovery again.
cooper
***@***.***
From: Johan Stokking
Date: 2024-11-11 17:50
To: TheThingsNetwork/lorawan-devices
CC: cooper99-ui; Mention
Subject: Re: [TheThingsNetwork/lorawan-devices] Add makerfabs (PR #844)
@cooper99-ui it is listed here: https://www.thethingsnetwork.org/device-repository/devices/makerfabs/ath20/. In The Things Stack, it will be part of the next release.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@cooper99-ui please use |
|
hi,Johan Stokking
I added some code for several products, but there were some problems in compiling and committing the code. I used make validate to compile the code without any problems, but I used make validate fmt to get an error saying "npm run format
***@***.*** format
prettier --write schema.json "vendor/**/*.yaml" "bin/**/*.js"
sh: 1: prettier: not found
make: *** [Makefile:45: fmt] error 127 "I searched the Internet for some fixes, but still got this error when I ran this command. Another problem is that when I execute the make deps instruction, I have been failing to download and reporting that I cannot access the go server. However, my network is good. I hope you can help me to check these two problems and look forward to your reply.
copper
***@***.***
From: Johan Stokking
Date: 2024-11-08 17:26
To: TheThingsNetwork/lorawan-devices
CC: cooper99-ui; Mention
Subject: Re: [TheThingsNetwork/lorawan-devices] Add makerfabs (PR #844)
hi,Johan Stokking I have seen the changed part, which is the file I added. Thank you very much for your help. I have more than ten products to add to the repository later, do you think it is OK to operate like this product? Looking forward to your reply again cooper
This product looks good, the codec too. I would rename the product name next time, it's all lowercase now.
The issue is likely caused by a code editor and/or file formatter. Best is to disable those.
―
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@cooper99-ui if you can file a PR with only the concerning files, we'll take it from there, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add makerfabs
Changes
Checklist for Reviewers
profileIDsshould not bevendorIDand should be a unique value for every profile.index.yamlfile.Notes for Reviewers
...
Release Notes