Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types we expect for schema:workExample in ODL feed #2226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update types we expect for schema:workExample in ODL feed #2226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/palace/manager/opds/palace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,12 @@ class WorkExample(BaseOpdsModel):
]
"""

type: PublicationTypes | None = Field(None, alias="@type")
book_format: BookFormat | None = Field(None, alias="schema:bookFormat")
# TODO: I believe that type should be a PublicationType, and bookFormat should be
# a BookFormat, but we are seeing failures on some items coming in due to this,
# so we need to confirm with DeMarque what we should be expecting here, before
# switching the types.
type: str | None = Field(None, alias="@type")
book_format: str | None = Field(None, alias="schema:bookFormat")
isbn: str | None = Field(None, alias="schema:isbn")


Expand Down
Loading