Fix format sweep script by ensuring all operations within the context… #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2216 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 363 363
Lines 41274 41284 +10
Branches 8837 8838 +1
=======================================
+ Hits 37606 37616 +10
Misses 2406 2406
Partials 1262 1262 ☔ View full report in Codecov by Sentry. |
jonathangreen
approved these changes
Dec 18, 2024
… manager are performed on the same session.
dbernstein
force-pushed
the
fix-format-sweep-context-errors
branch
from
6b966e3 to
d21dae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… manager are performed on the same session.
Description
This is a follow-up PR to #2181. #2181 fixed the bug at a particular but it revealed another similar issue with the database session associated with the object being different from the session associated with the context manager further down the execution path. I didn't see any other uses of Session.object_session() in this execution path so I thing this should fix this issue with the format sweep scripts.
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1956
How Has This Been Tested?
Checklist