[PP-1956] Ensure the context transaction manager is being used for cr…

[dbernstein]

…eating identifiers in SweepMonitor runs.

Description

This PR attempts to fix a problem we are seeing in production where the database session associated with the identifier object (obtained via the Session.object_session() method ) is sometimes not the same as the one associated with the context manager when the sweep monitor is running. I'm not sure that this will fix it, but hopefully is will get us closer to a fix for the sweep monitors.

Motivation and Context

https://ebce-lyrasis.atlassian.net/browse/PP-1956

How Has This Been Tested?

Unit tests still pass.

Checklist

• I have updated the documentation accordingly.
• All new and existing tests passed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (1d1b4eb) to head (199fc5d).
Report is 27 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2181   +/-   ##
=======================================
  Coverage   91.01%   91.02%           
=======================================
  Files         361      361           
  Lines       41205    41209    +4     
  Branches     8849     8851    +2     
=======================================
+ Hits        37504    37509    +5     
+ Misses       2425     2424    -1     
  Partials     1276     1276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonathangreen]

@dbernstein why do think that we are getting the wrong session here? I'm trying to understand how that could happen.

[jonathangreen]

This one has been going for a LONG time at this point, and it seems like we are adding fixes on top of other fixes to try to get this sorted out, but it hasn't been working, I'm not sure I'm comfortable adding another fix here without understanding why this is happening.

This issue is related to at least these two other PRs: #1948 (PP-1491) & #2091 (PP-1755). Perhaps we need to go back to the original problem, and see if there is a better approach that we can take there so we get this actually sorted.

[jonathangreen]

@dbernstein i approved this one, because I don't think its going to cause any issues, but I also don't see how it will help the problem here.

[dbernstein]

@jonathangreen : My thinking here is that at least we're ensuring that the session that is being used by the identifier class to add a link is the same same that is being used by the context manager. Unless I have fundamentally misunderstood something here.