Fix docker migration test CI workflow (PP-1171) #1800
Conversation
jonathangreen
force-pushed
the
feature/fix-ci
branch
from
1fb54b9 to
52f402b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.01%
==========================================
Files 259 259
Lines 28663 28663
Branches 6515 6515
==========================================
- Hits 25887 25885 -2
- Misses 1839 1840 +1
- Partials 937 938 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@jonathangreen : I just never stop admiring your skillz, dog. 🥇 You set a high bar.
docker/ci/test_migrations.sh
Outdated
| check_db "A new migration is required or a up migration is broken." | ||
| gh_group "Testing upgrade migrations" | ||
| run_migrations "webapp" "upgrade head" | ||
| check_db "webapp" "A new migration is required or a up migration is broken." |
docker/ci/test_migrations.sh
Outdated
| run_migrations "upgrade head" | ||
| check_db "A new migration is required or a up migration is broken." | ||
| gh_group "Testing upgrade migrations" | ||
| run_migrations "webapp" "upgrade head" |
There was a problem hiding this comment.
Should this be" webapp-old" here?
There was a problem hiding this comment.
It can't be webapp-old because the old container doesn't have the migrations in it in order to move to the latest DB version.
There was a problem hiding this comment.
okay - right of course: I get it now - one database container is shared by the two web app instances.
Description
Update
docker/ci/test_migrations.sh:test_migrations.ymlwas added for this purposeMotivation and Context
Previously we tried to build a container based on the old version of the codebase for these tests. That is an error prone endeavor, and failed in this case because of the change in dependencies in the container build introduced in #1799.
In order to reduce the chances of this failing in the future, we just use an old previously build version of the container. This also simplifies the script, since it no longer has to move back and forth between old and new git commits in order to run the tests.
How Has This Been Tested?
Checklist