-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per-medium breakouts to dashboard statistics inventories. (PP-728) #1549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a couple lines of commented out testing code that should get cleaned up before merging, but otherwise looks good to me! 🎸
I also left a couple minor comments, but as always feel free to make those changes or just merge as is.
- Move main method to top of class for better visibility. - Turn static methods into functions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
==========================================
+ Coverage 90.17% 90.18% +0.01%
==========================================
Files 234 234
Lines 28187 28215 +28
Branches 6455 6456 +1
==========================================
+ Hits 25418 25447 +29
Misses 1831 1831
+ Partials 938 937 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jonathangreen I made some substantial changes while following your suggestion to use a Also, codecov seems to have lost its mind. I just manually verified that the tests were hitting lines that it claimed they were missing. 🤷🏽♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great!
Description
This work requires changes to the circulation admin UI. The following work is required before this PR can be moved out of
draft
status and merged:circulation-admin
and make the changes required for PP-728.These changes are introduced in circulation-admin PR 98.
circulation-admin
.circulation-admin
.Note:
Motivation and Context
Need to support additional detail by type of medium (book, audiobook, etc.).
[Jira PP-728]
How Has This Been Tested?
Checklist