Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection barchart tooltip stats breakdown by medium, when available. (PP-728) #98

Merged
merged 10 commits into from
Dec 8, 2023

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Dec 7, 2023

Description

  • Adds breakdown by medium (when available) to collection inventory barchart tooltip.
  • Removes the "self-hosted" metric from inventory and collection displays.

Note:

  • Circulation Manager changes to provide a breakdown of inventory metrics by medium are introduced on circulation PR 1549.
  • This version is backward compatible with older versions of the circulation manager that do not provide per-medium inventory breakouts. When the detail is not available, the breakdown is not provided in the UI.

Motivation and Context

Need for metrics by medium (book, audio, etc.) when reviewing inventory.

[Jira PP-728]

How Has This Been Tested?

  • New tests added and small updates to existing tests.
  • Manual local testing.
  • All tests pass in development environment.
  • CI tests passed for associated feature branch.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@tdilauro tdilauro merged commit c638cf6 into main Dec 8, 2023
1 check passed
@tdilauro tdilauro deleted the feature/stats-data-with-media-breakout branch December 8, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants