-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging #4
Packaging #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
A couple things:
- I'm not strong on the front-end stuff, so it may be good to have Ray look at the
.npmignore
and webpack config changes. - You didn't touch this, but I was wondering about the Nightwatch/Selenium stuff mentioned in the README. Is that really running somewhere?
@ray-lee these changes are very similar to the changes in ThePalaceProject/library-registry-admin#3. Do you mind taking a look at the webpack config and |
.sass-lint.yml | ||
/*.json | ||
/webpack.*.js | ||
/.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but at some point we may want to whitelist via the files
property in package.json
. https://docs.npmjs.com/cli/v7/configuring-npm/package-json#files
options: { | ||
'limit': 10000, | ||
'name': 'assets/[hash].[ext]' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as #3: We should check if files that are not inlined are able to be loaded by the app when the JS bundle is loaded from a CDN.
Description