-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm dev-server script to develop against a remote CM back-end. #12
Conversation
I did some more testing of this today and it seems to work well. I connected it to several servers and navigated around the interface. |
5. run the Elasticsearch server using `./bin/elasticsearch` in the elasticsearch-[version] directory, | ||
6. visit `localhost:6500/admin/`. | ||
|
||
Webpack will take care of compiling and updating any new changes made locally for development. Just hard refresh the page (command + shift + R) to see updates without having to restart either the `circulation` or `circulation-web` servers. | ||
Webpack will take care of compiling and updating any new changes made locally for development. Just hard refresh the page (command + shift + R) to see updates without having to restart either the `circulation` or `circulation-admin` servers. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I took the opportunity to change the directory names in the above existing documentation, but I don't think the instructions actually work as written. There is no package.json in circulation/api/admin, so the npm commands don't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there isn't. I think JG started down the path of cleaning up the README in #4, but got waylaid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to only leave in the parts about the new web server and revert the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
See the discussed README issues, which I don't feel strongly about, since there's still a bunch more to do there.
5. run the Elasticsearch server using `./bin/elasticsearch` in the elasticsearch-[version] directory, | ||
6. visit `localhost:6500/admin/`. | ||
|
||
Webpack will take care of compiling and updating any new changes made locally for development. Just hard refresh the page (command + shift + R) to see updates without having to restart either the `circulation` or `circulation-web` servers. | ||
Webpack will take care of compiling and updating any new changes made locally for development. Just hard refresh the page (command + shift + R) to see updates without having to restart either the `circulation` or `circulation-admin` servers. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to only leave in the parts about the new web server and revert the rest.
I think some of the readme changes need to be there to make the new stuff make sense, and it's an improvement, even if it's still not correct. I'd rather leave it, and come back to fix all the problems. |
Description
This adds a new npm script,
dev-server
, which runs a local development server that proxies requests to a specified CM back-end.It also:
eval-source-map
.Motivation and Context
This allows development on circulation-admin to happen without the need to build a local circulation manager from source. It makes it easier for front-end developers to get started on the project, as they don't need to install a python ecosystem, elasticsearch, etc. It also allows data from "real" CMs to be used during development, without needing to dump and restore databases.
How Has This Been Tested?
npm run dev-server -- --env=backend=https://gorgon.tpp-qa.lyrasistechnology.org
Checklist: