navlink tabindex -1 #991
Closed
navlink tabindex -1 #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops - sorry, I only saw your pull request after implementing my own bug fix. BTW, my solution is similar to you solution. The difference is that my solution covers b:navLink, b:commandLink, b:dropMenu, b:dropButton, b:navBar, b:link, and b:commandLink. Plus, I saw that we render the tabindex twice (and inconsistently) if it's explicitly defined by the programmer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#989 this seems to fix the problem in the showcase. not sure if it has any side effects though