Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navLink and navCommandLink not compatible with keyboard navigation #989

Closed
Lb-lea opened this issue Aug 9, 2018 · 3 comments
Closed

navLink and navCommandLink not compatible with keyboard navigation #989

Lb-lea opened this issue Aug 9, 2018 · 3 comments
Milestone

Comments

@Lb-lea
Copy link

Lb-lea commented Aug 9, 2018

Hello,
it seems that those two items are being skipped during keyboard navigation.
You can see it on the first example here : when using tab, the selection goes from the brand link to the dropdown one skipping the two in between links. It makes the whole thing un-accessible for keyboards only users.
It would be great if there was a fully navigable navbar component.

@stephanrauh
Copy link
Collaborator

This ticket probably needs some investigation, but you're right, it's one of the things we definitely should support.

@Lb-lea
Copy link
Author

Lb-lea commented Aug 10, 2018

I'm not sure but from what I gather it might been due to the tabindex="-1" attribute in the generated link.
"A tabindex="-1" value removes the element from the default navigation flow"

Edit:
It is not much of a problem since we can choose the tabindex attribute. for me tabindex="0" fixed the issue. You might consider having 0 be the default instead of -1 though.

@stephanrauh
Copy link
Collaborator

Now keyboard navigation works a lot better. Thanks for reporting the bug and for suggesting the solution!

stephanrauh added a commit to TheCoder4eu/BootsFacesWeb that referenced this issue Aug 11, 2018
@TheCoder4eu TheCoder4eu added this to the v1.4.0 milestone Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants