Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#662 BS feedback and error classes fixed #662

Merged
merged 4 commits into from
Mar 22, 2017

Conversation

sergiowww
Copy link
Contributor

#621 error feedback classes over containers, not over fields and labels

@sergiowww
Copy link
Contributor Author

Please, do not merge yet, I'll run some tests to check if there's no loose ends...

@sergiowww
Copy link
Contributor Author

Now it is ok to merge...

@sergiowww sergiowww changed the title BS feedback and error classes fixed #662 BS feedback and error classes fixed Mar 22, 2017
@stephanrauh stephanrauh merged commit c5ba4c0 into TheCoder4eu:master Mar 22, 2017
@stephanrauh
Copy link
Collaborator

Look OK at first glance. Now for the hard task: documentation :).

@stephanrauh
Copy link
Collaborator

I've added some documentation for the dateTimePicker (see TheCoder4eu/BootsFacesWeb@13b8dbd).

@stephanrauh
Copy link
Collaborator

Woud you like to finish the documentation for the other components? It's mostly a simple copy and paste job, and I'd appreciate this a lot.

Thanks in advance
Stephan

@sergiowww
Copy link
Contributor Author

Sure, I'll do it!

@stephanrauh
Copy link
Collaborator

@sergiowww May I mention your name in the "Kudos" section of the BootsFaces 1.1.0 announcement post?

@sergiowww
Copy link
Contributor Author

@stephanrauh Yes! No problem... sorry I took so long to reply, it's been a rush lately!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants