Validation error style classes problem

[NicolaIsotta]

Sorry to bother you guys, but I'm pretty sure there's a problem with error style classes.
Here's the HTML from your showcase of a input text with failed validation:

The issue is that the has-error class should be added to the form-group div, not to the label or input elements; source: http://getbootstrap.com/css/#forms-control-validation
Also, the bf-error class and its equivalents should be removed, or at least have no default css rules, because they override bs default styles.

[stephanrauh]

The Bootstrap style looks better, too.

I just wonder how to implement this without breaking backward compatibility. I'm sure many developers rely on the bf-* classes.

[stephanrauh]

@TheCoder4eu @zhedar @asterd Any thoughts on this? I'd love to collect your feedback before I start implementing something and breaking the applications of several thousand developers.

[TheCoder4eu]

@stephanrauh it depends on how they rely on the bf-* classes.
If they rely only on its presence, we just need to keep adding this classes as before removing the associated styles and applying in addition the Bootstrap classes correctly.

[TheCoder4eu]

@stephanrauh can we close this issue too?

[TheCoder4eu]

@stephanrauh can we close this issue?

[stephanrauh]

I'd like to keep this ticket open. I think we should support the Bootstrap approach, too.

[sergiowww]

I've been hung up on the same problem, the has-error class should be added to the form-group container. Neither the input field nor the field's label should receive feedback classes, it is exactly what @NicolaIsotta said. I've cloned the project and I'll submit a PR as soon as I fix it, I don't know if this issue has been fixed, so please, if anyone have any news about it, keep us updated!

!

[stephanrauh]

OK, go ahead!

For the sake of backward compatibility, please make the error classes configurable:

• check the parameter legacyErrorClasses of the web.xml:
  BsfUtils.getInitParam("net.bootsfaces.legacy_error_classes");
• render the old (and wrong) style if the parameter is set to true
• render the new style if the parameter is empty or false

Thanks in advance!
Stephan

[sergiowww]

Copy that! Thanks!

[sergiowww]

The Pull Request is ready for approval!

[stephanrauh]

I've merged the PR. Todos left:

• document the feature
• double-check if the PR already covers every component able to display error messages

[stephanrauh]

The feature is still broken with:

• <b:colorPicker>
• <b:slider>
• <b:slider2>

[TheCoder4eu]

@stephanrauh , did the commit 2ab0b09 fix also Slider and Slider2?
We can close this issue?

[stephanrauh]

It solved the bug partially. But it's good enough to close the issue.