Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectOneMenu visual problem since 1.4.2 #1097

Closed
fdzaebel opened this issue Oct 3, 2019 · 6 comments · Fixed by #1119 or #1095
Closed

selectOneMenu visual problem since 1.4.2 #1097

fdzaebel opened this issue Oct 3, 2019 · 6 comments · Fixed by #1119 or #1095

Comments

@fdzaebel
Copy link

fdzaebel commented Oct 3, 2019

Hello together,

since version 1.4.2 of BootsFaces the b:selectOneMenu component is not good readable on Safari browsers. Please see an attached example picture.
Bildschirmfoto 2019-10-03 um 18 08 50

With version 1.4.1 everything was fine.

It would be great if anybody could give me a quick workaround for this.

Thanks a lot!

@geopossachs
Copy link
Collaborator

Hello, @fdzaebel thank you for your feedback.

I believe the bug was coming with the fix for #1090
You can take a look at the CSS of 'select' and change it.
If you find a solution we are interested in it too

@fdzaebel
Copy link
Author

fdzaebel commented Oct 3, 2019

You can take a look at the CSS of 'select' and change it.
If you find a solution we are interested in it too

Do you mean this select?

select {
        -webkit-appearance: none;

        -moz-appearance: none;

        appearance: none;

        background: url(dropdown.ico) right / 20px no-repeat #fff;

        padding-right: 20px;
}

@geopossachs
Copy link
Collaborator

yes, i mean this section

@fdzaebel
Copy link
Author

fdzaebel commented Oct 3, 2019

I Am very sorry but I am not a CSS specialist.

But I tried around with BootsFaces "select2=true" option and can say that using this option everything looks ok in IE, Firefox and Safari.
safari
ie
ff

Does this help?

@sebsoftware
Copy link
Contributor

Upgrading to Bootswatch does not fix this issue.
After setting -webkit-appearance to none the line height is set to 30px by the core.css for a "sm" sized select i.E.. With -webkit-appearance set to the default "menu list-button" it works fine. Another way would be modifying the line-height to individual values in bsf.css.

sebsoftware added a commit to sebsoftware/BootsFaces-OSP that referenced this issue Jan 14, 2020
If field-size is set to sm or lg. Text was wrongly positioned in Safari, Chrome or Firefox on MacOS (I think even in Windows IE or Edge). Also background image overlayed long text elements, resulting in a strange view.

Fixes: TheCoder4eu#1097
sebsoftware added a commit to sebsoftware/BootsFaces-OSP that referenced this issue Jan 14, 2020
The select was rendered distorted in Safari, Chrome, Firefox on macos after the fixing TheCoder4eu#1090. The no longer set -webkit-appearance to menubutton-list is no longer overriding the line-height. This was set wrongly for field sizes other than md. Also long text was overlayed by arrow images.

Fixes TheCoder4eu#1097
@stephanrauh
Copy link
Collaborator

It seems updating to Bootstrap 3.4.1 fixes the problem. Can you please verify if it works on the source I've just pushed to GitHub?

@geopossachs geopossachs linked a pull request May 2, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants