Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bootstrap to v3.4.1 and Bootswatch themes to v3.4.1+1 and test. #1093

Closed
TheCoder4eu opened this issue Aug 31, 2019 · 8 comments · Fixed by #1103
Closed

Upgrade Bootstrap to v3.4.1 and Bootswatch themes to v3.4.1+1 and test. #1093

TheCoder4eu opened this issue Aug 31, 2019 · 8 comments · Fixed by #1103
Assignees
Labels
css enhancement Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation.
Milestone

Comments

@TheCoder4eu
Copy link
Owner

Upgrade Bootstrap to v3.4.1 and Bootswatch themes to v3.4.1+1 and test.

@TheCoder4eu TheCoder4eu added this to the v1.5.0 milestone Aug 31, 2019
@TheCoder4eu TheCoder4eu self-assigned this Aug 31, 2019
@mtvweb
Copy link

mtvweb commented Oct 25, 2019

With 3.4.1 the filter field and pagination buttons of the data table looks strange. (But seems to be a DataTables problem)
Even the b:selectOneMenu text is not positioned well. At least with field-size="sm"

@geopossachs
Copy link
Collaborator

geopossachs commented Oct 25, 2019

hello @mtvweb that's wonderful that you want to support the project.

i would like to review your changes. It is possible to shorten the pull request to the central changes here? (rebase; cherry pick; ...)

@geopossachs
Copy link
Collaborator

Even the b:selectOneMenu text is not positioned well. At least with field-size="sm"
#1097

stephanrauh added a commit that referenced this issue Apr 29, 2020
@stephanrauh
Copy link
Collaborator

@mtvweb I don't see any problems with the datatable. I've just pushed the update to Boostrap 3.4.1, and I've also published a new snapshot on Maven Central. Can you have a look if the glitches you've reported are still there?

@stephanrauh stephanrauh added the Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation. label Apr 29, 2020
@mtvweb
Copy link

mtvweb commented Apr 29, 2020

I think Datatables problem is already fixed in master by upgrading datatables.net to a newer version by @geopossachs

@stephanrauh
Copy link
Collaborator

We've finally managed to solve the showcase bug. Now the datatable looks mostly OK, apart from the first dropdown. Does anyone have an idea why this happens?

@mtvweb
Copy link

mtvweb commented May 10, 2020

Is the current version only at your showcase?

The dropdown doesn't reference an entry in the data tables.css
I can see a difference in the header

Your header:
`
/*

Header at https://bootsfaces.sebsoftware.de
`/*

@mtvweb
Copy link

mtvweb commented May 10, 2020

Just checked out your current GitHub repository, and build it. Everything looks fine.

@geopossachs geopossachs linked a pull request May 12, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css enhancement Solved This ticket has been solved. If it's still open, we're waiting for the user's confirmation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants