Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on Python 3.11 #6591

Merged
merged 20 commits into from
Oct 31, 2022
Merged

Test on Python 3.11 #6591

merged 20 commits into from
Oct 31, 2022

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Oct 3, 2022 •
edited
Loading

Describe your change:

Problem deps are qiskit, statsmodels, and tensorflow:

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner October 3, 2022 07:32
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Oct 3, 2022
@dhruvmanila
Copy link
Member

I don't think there's any point in testing out on latest Python versions as dependencies such as those in the ML/DS side takes time to support them.

@cclauss
Copy link
Member Author

cclauss commented Oct 9, 2022 •
edited
Loading

Do you mean like symengine/symengine.py#422 ? or srnas/barnaba#51 or scipy/scipy#16851?

I will continue pushing this repo and our deps to upgrade. 22% is a significant improvement.

@dhruvmanila
Copy link
Member

Oh I see, that's fine then 👍

@cclauss
Copy link
Member Author

cclauss commented Oct 9, 2022

statsmodels/statsmodels#8287

@cclauss
Copy link
Member Author

cclauss commented Oct 26, 2022 •
edited
Loading

@JatinR05 created a nice benchmark that allows us to compare the speed of Python 3.11 vs 3.10...

% brew install [email protected] [email protected]
% python3.10 bit_manipulation/count_number_of_one_bits.py
% python3.11 bit_manipulation/count_number_of_one_bits.py

Benchmark when number = 25:
get_set_bits_count_using_modulo_operator(number) = 3
**Python 3.10** -- timeit() runs in 0.3546215830137953 seconds
**Python 3.11** -- timeit() runs in 0.283035458996892 seconds

get_set_bits_count_using_brian_kernighans_algorithm(number) = 3
**Python 3.10** -- timeit() runs in 0.2019664169929456 seconds
**Python 3.11** -- timeit() runs in 0.13870316700194962 seconds

@cclauss cclauss changed the title Test on Python 3.11 release candidate 2 Test on Python 3.11 Oct 26, 2022
@cclauss cclauss mentioned this pull request Oct 28, 2022
Merged
14 tasks
@algorithms-keeper algorithms-keeper bot added merge conflicts Open a new PR or rebase on the latest commit and removed tests are failing Do not merge until tests pass labels Oct 31, 2022
@algorithms-keeper algorithms-keeper bot removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 31, 2022
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 31, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 31, 2022
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 31, 2022
@cclauss cclauss merged commit a31edd4 into master Oct 31, 2022
@cclauss cclauss deleted the Python-3.11 branch November 1, 2022 17:58
@cclauss cclauss mentioned this pull request Dec 15, 2022
Merged
14 tasks
@tianyizheng02 tianyizheng02 mentioned this pull request Jun 13, 2023
Open
@cclauss cclauss mentioned this pull request Jun 25, 2023
Merged
14 tasks
cclauss added a commit that referenced this pull request Jun 25, 2023
@cclauss
GitHub Actions build: Add more tests
9228f73 
Re-enable some tests that were disabled in #6591.
Fixes #8818
cclauss added a commit that referenced this pull request Jun 25, 2023
@cclauss
GitHub Actions build: Add more tests (#8837)
3bfa89d 
* GitHub Actions build: Add more tests

Re-enable some tests that were disabled in #6591.
Fixes #8818

* updating DIRECTORY.md

* TODO: Re-enable quantum tests

* fails: pytest quantum/bb84.py quantum/q_fourier_transform.py

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
cclauss added a commit that referenced this pull request May 10, 2024
@cclauss
DRAFT: GitHub Actions: Test on Python 3.13 beta release
b31939c 
https://www.python.org/downloads/release/python-3130b1/

Like:
* #9306
* #8777
* #6591
* #5992
* #4396
* #3926
* #2279
@cclauss cclauss mentioned this pull request May 10, 2024
Closed
15 tasks
sedatguzelsemme pushed a commit to sedatguzelsemme/Python that referenced this pull request Sep 15, 2024
@cclauss @sedatguzelsemme
GitHub Actions build: Add more tests (TheAlgorithms#8837)
aca2d9b 
* GitHub Actions build: Add more tests

Re-enable some tests that were disabled in TheAlgorithms#6591.
Fixes TheAlgorithms#8818

* updating DIRECTORY.md

* TODO: Re-enable quantum tests

* fails: pytest quantum/bb84.py quantum/q_fourier_transform.py

---------

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
cclauss added a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@cclauss
DRAFT: GitHub Actions: Test on Python 3.13 beta release
fee0797 
https://www.python.org/downloads/release/python-3130b1/

Like:
* TheAlgorithms#9306
* TheAlgorithms#8777
* TheAlgorithms#6591
* TheAlgorithms#5992
* TheAlgorithms#4396
* TheAlgorithms#3926
* TheAlgorithms#2279
cclauss added a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@cclauss
DRAFT: GitHub Actions: Test on Python 3.13
24614a7 
https://www.python.org/downloads/release/python-3130b1/

Like:
* TheAlgorithms#9306
* TheAlgorithms#8777
* TheAlgorithms#6591
* TheAlgorithms#5992
* TheAlgorithms#4396
* TheAlgorithms#3926
* TheAlgorithms#2279
cclauss added a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@cclauss
DRAFT: GitHub Actions: Test on Python 3.13
c51c02a 
https://www.python.org/downloads/release/python-3130b1/

Like:
* TheAlgorithms#9306
* TheAlgorithms#8777
* TheAlgorithms#6591
* TheAlgorithms#5992
* TheAlgorithms#4396
* TheAlgorithms#3926
* TheAlgorithms#2279
cclauss added a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@cclauss
DRAFT: GitHub Actions: Test on Python 3.13 beta release
828510c 
https://www.python.org/downloads/release/python-3130b1/

Like:
* TheAlgorithms#9306
* TheAlgorithms#8777
* TheAlgorithms#6591
* TheAlgorithms#5992
* TheAlgorithms#4396
* TheAlgorithms#3926
* TheAlgorithms#2279
cclauss added a commit to cclauss/Python that referenced this pull request Sep 30, 2024
@cclauss
DRAFT: GitHub Actions: Test on Python 3.13 beta release
51eba70 
https://www.python.org/downloads/release/python-3130b1/

Like:
* TheAlgorithms#9306
* TheAlgorithms#8777
* TheAlgorithms#6591
* TheAlgorithms#5992
* TheAlgorithms#4396
* TheAlgorithms#3926
* TheAlgorithms#2279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@onlinejudge95 onlinejudge95 Awaiting requested review from onlinejudge95

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @dhruvmanila @poyea