Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python 3.10 #5992

Merged
merged 4 commits into from
Feb 13, 2022
Merged

Upgrade to Python 3.10 #5992

merged 4 commits into from
Feb 13, 2022

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Feb 12, 2022

Describe your change:

Replaces #4396

  • Fix CI
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner February 12, 2022 20:41
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 12, 2022
@cclauss cclauss requested a review from poyea February 12, 2022 20:41
@ghost ghost added the tests are failing Do not merge until tests pass label Feb 12, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Feb 12, 2022
@cclauss
Copy link
Member Author

cclauss commented Feb 12, 2022

After this is approved and landed, we can have a followup PR to fix mypy.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Feb 12, 2022
@cclauss cclauss merged commit f707f6d into TheAlgorithms:master Feb 13, 2022
@cclauss cclauss deleted the py310 branch February 13, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants