Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies improve templates, fix CI workflow, support net46 #11

Merged
merged 25 commits into from
Oct 6, 2020

Conversation

rdeago
Copy link
Member

@rdeago rdeago commented Oct 5, 2020

Types of changes

  • Bugfix
  • Enhancement (new and/or improved behavior)
  • Refactoring (no functional changes)
  • Code style update (no functional changes)
  • Dependencies added, updated, or removed
  • Build related changes
  • CI related changes
  • Documentation update
  • Other (please describe below)

Proposed changes / fixed issues

  • Update Mono.Cecil 0.11.2 -> 0.11.3
  • Update Buildvana.Sdk 1.0.0-alpha.4 ->1.0.0-alpha.7
  • Improve issue / PR templates.
  • Implement build matrix in CI workflow.
  • Identify action versions better.
  • Standardize changelog style.
  • Standardize copyright holders between license file and headers.
  • Update various editor / analyzer / ReSharper settings.

Checklist

  • My contribution is either my original work, or comes from projects with an MIT-compatible license, in which case I have updated the THIRD-PARTY-NOTICES file accordingly
  • I have added and/or updated related documentation (if applicable)
  • I have updated the "Unreleased changes" section in CHANGELOG.md according to the modifications I made

Other information

@github-actions github-actions bot removed the area-deps label Oct 5, 2020
…inue.

This will let us diagnose weird 'dotnet test' failures.
@rdeago rdeago changed the title Update dependencies Update dependencies improve templates, fix CI workflow Oct 6, 2020
@rdeago
Copy link
Member Author

rdeago commented Oct 6, 2020

Let's recap:

  1. We have to install .NET Core 2.1 just to run ExportAnnotations from ReSharper.ExportAnnotations.Task. This is bad, but not an issue with our workflow. I'm opening an issue about this on the other repo.
  2. Testing fails with .NET 5-rc1. Probably not an issue with out workflow either, as there are open issues about very similar problems: dotnet test error MSB4181: The "Microsoft.TestPlatform.Build.Tasks.VSTestTask" task returned false but did not log an error dotnet/sdk#13431 Strange message if test fails with preview 5.0.100-preview.2.20176.6 microsoft/vstest#2384
  3. LGTM fails too! Although it was bound to fail anyway, due to the stray NuGet.config file currently present in the main branch and preventing restore to succeed, the build log for the PR shows a weird "not found" exception that would better investigated upon when the ExportAnnotation tool is fixed.

Keeping this PR on hold for now.

@rdeago rdeago changed the title Update dependencies improve templates, fix CI workflow Update dependencies improve templates, fix CI workflow, support net46 Oct 6, 2020
@rdeago rdeago changed the title Update dependencies improve templates, fix CI workflow, support net46 Update dependencies improve templates, fix CI workflow, support net46 Oct 6, 2020
@rdeago rdeago added area-build enhancement [issue/PR] requests / implements new or improved functionality. labels Oct 6, 2020
@github-actions github-actions bot removed the area-deps label Oct 6, 2020
@rdeago
Copy link
Member Author

rdeago commented Oct 6, 2020

To stop the vicious cycle formed by of this PR,Tenacom/ReSharper.ExportAnnotations#20, and #12, I'm merging this. We'll investigate CI /LGTM issues later.

@rdeago rdeago merged commit 7d6063d into Tenacom:main Oct 6, 2020
@rdeago rdeago deleted the update-dependencies branch October 6, 2020 09:36
@rdeago rdeago mentioned this pull request Oct 11, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [issue/PR] requests / implements new or improved functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant